Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add $id field to schema with versioned URL #18

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Add $id field to schema with versioned URL #18

merged 1 commit into from
Jun 13, 2023

Conversation

camargo
Copy link
Member

@camargo camargo commented Jun 12, 2023

Resolves #16

@camargo camargo self-assigned this Jun 12, 2023
@camargo camargo added the feature A new feature or feature request label Jun 12, 2023
@camargo camargo force-pushed the feat/schema-id-field branch from f71e018 to c26de58 Compare June 12, 2023 23:08
@camargo camargo requested review from cohansen and mschaffejpl June 12, 2023 23:10
cohansen
cohansen approved these changes Jun 12, 2023
View reviewed changes
Copy link
Collaborator

@cohansen cohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another manual place to forget to update the version 😵

@camargo
Copy link
Member Author

camargo commented Jun 12, 2023

@cohansen haha! Yeah, there must be a better way :(

@camargo camargo force-pushed the feat/schema-id-field branch from c26de58 to db5d756 Compare June 13, 2023 15:54
@camargo camargo force-pushed the feat/schema-id-field branch from db5d756 to 1877219 Compare June 13, 2023 16:56
@camargo camargo merged commit 8ee390d into develop Jun 13, 2023
@camargo camargo deleted the feat/schema-id-field branch June 13, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cohansen cohansen cohansen approved these changes

@mschaffejpl mschaffejpl Awaiting requested review from mschaffejpl

Assignees

@camargo camargo

Labels
feature A new feature or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SEQ JSON Schema $id URI resolvable
2 participants
@camargo @cohansen