Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEQ JSON Schema $id URI resolvable #16

Closed
dlconner opened this issue May 3, 2023 · 1 comment · Fixed by #18
Closed

SEQ JSON Schema $id URI resolvable #16

dlconner opened this issue May 3, 2023 · 1 comment · Fixed by #18
Assignees
@camargo
Labels
feature A new feature or feature request

Comments

@dlconner
Copy link

dlconner commented May 3, 2023

Checked for duplicates

Yes - I've already checked

Is this a regression?

No - This is a new bug

Version

1.3.0

Describe the bug

$id should be a resolvable URI.
For Example: v1.0.17 should be:
https://github.com/NASA-AMMOS/seq-json-schema/tree/v1.0.17

This would allow users to validate against the schema without downloading and including in code.

Reproduction

visual

Logs

No response

System Info

v1.0.17

Severity

Annoyance
@dlconner dlconner added the bug Something isn't working label May 3, 2023
@joswig joswig transferred this issue from NASA-AMMOS/aerie May 8, 2023
@camargo camargo added feature A new feature or feature request and removed bug Something isn't working labels May 9, 2023
@dlconner
Copy link
Author

Please add to the next version please @camargo

@camargo camargo mentioned this issue Jun 12, 2023
Merged
@camargo camargo self-assigned this Jun 12, 2023
@camargo camargo moved this from Todo to In Review in Aerie Jun 12, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Aerie Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camargo camargo

Labels
feature A new feature or feature request
Projects
Aerie
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add $id field to schema with versioned URL NASA-AMMOS/seq-json-schema
2 participants
@camargo @dlconner