Issue #196 - Fix UI Time64 decode handling of 0 value #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nttoole
reviewed
Mar 5, 2021
| @@ -206,7 +206,11 @@ class Time32Type extends TimeType | |||
| class Time64Type extends TimeType | |||
| { | |||
| decode (raw) { | |||
| const parts = String(raw).split('.').map(x => parseInt(x)) | |||
| let parts = [0, 0] | |||
There was a problem hiding this comment.
Is '0' the only case where a decimal would be missing? If not, should the check be for '.', if found, usual logic, otherwise parts = [ parseInt(raw), 0] ?
There was a problem hiding this comment.
That's a very good question @nttoole. I'll poke
There was a problem hiding this comment.
Updated in line with your recommendation @nttoole
If raw % 1 === 0 it's not a float and we need to handle that edge case. Otherwise we stick with the normal approach.
Good catch
Update Time64 decode function's handling of non-float values to prevent a bogus Date object being created. Resolve #196
nttoole
approved these changes
Mar 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Time64 decode function's handling of 0 value to prevent a bogus
Date object being created.
Resolve #196