Time64 value handling fails when given a 0 value #196
Comments
MJJoyce
added a commit
that referenced
this issue
Mar 5, 2021
Update Time64 decode function's handling of 0 value to prevent a bogus Date object being created. Resolve #196
MJJoyce
added a commit
that referenced
this issue
Mar 6, 2021
Update Time64 decode function's handling of non-float values to prevent a bogus Date object being created. Resolve #196
MJJoyce
added a commit
that referenced
this issue
Mar 10, 2021
Issue #196 - Fix UI Time64 decode handling of 0 value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Time64 decoding expects to get a floating point value >= 0. Javascript (not surprisingly I suppose =) treats
0.0as0and passes that off to the decode. We attempt to split that float into seconds / microseconds and generate a date object from that. This fails when it gets0which can result in some interesting dates being shown in the UI.We need a bit of safeguarding in our handling of the value that Time64's decode function takes.
The text was updated successfully, but these errors were encountered: