Implement support for AOS frames #65
Conversation
config/config.yaml
Outdated
| responder_id: dsn_hmap | ||
| peer_password: lunahmap | ||
| version: 4 | ||
| telemetryframetype: AOS |
There was a problem hiding this comment.
Let's remove the project specific values from this PR, and change the parameter name and default type to downlink_frame_type: TMTransFrame
ait/dsn/sle/raf.py
Outdated
| @@ -334,7 +334,12 @@ def _transfer_data_invoc_handler(self, pdu): | |||
| ait.core.log.info(err) | |||
| return | |||
|
|
|||
| tmf = frames.TMTransFrame(tm_data) | |||
| if self._telemetryframetype == "TM": | |||
There was a problem hiding this comment.
This will be cleaner if we require the type passed in to be a valid class name rather than an abbreviation and then check dynamically for the class in frames.py. That way we don't have to edit this code in the future when additional frame types are added. Then this chunk can be changed to
tmf = getattr(frames, self._downlink_frame_type)
ait/dsn/sle/rcf.py
Outdated
| @@ -409,7 +409,12 @@ def _transfer_data_invoc_handler(self, pdu): | |||
| ait.core.log.info(err) | |||
| return | |||
|
|
|||
| tmf = frames.TMTransFrame(tm_data) | |||
| if self._telemetryframetype == "TM": | |||
ait/dsn/sle/common.py
Outdated
| @@ -97,6 +97,8 @@ class SLE(object): | |||
|
|
|||
| def __init__(self, *args, **kwargs): | |||
| '''''' | |||
| self. _telemetryframetype = ait.config.get('dsn.sle.telemetryframetype', | |||
There was a problem hiding this comment.
Let's update the attribute name, parameter name, and default to _downlink_frame_type, downlink_frame_type, and TMTransFrame respectively.
ait/dsn/sle/common.py
Outdated
| @@ -164,6 +166,7 @@ def add_handler(self, event, handler): | |||
| def send(self, data): | |||
| ''' Send supplied data to DSN ''' | |||
| try: | |||
|
|
|||
There was a problem hiding this comment.
Was this added by mistake?
| return | ||
|
|
||
| #offset to first byte of ccsds header (2047 means no data) | ||
| if self['first_hdr_ptr'] == b'11111111111': |
There was a problem hiding this comment.
I don't see where self['first_hdr_ptr'] is being assigned before this.
|
Requested changes in PR https://github.com/NASA-AMMOS/AIT-DSN/pull/69 |
Resolves #60