Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AOS Transfer Frames #60

Closed
aywaldron opened this issue Jun 10, 2019 · 3 comments · Fixed by #98
Closed

Implement AOS Transfer Frames #60

aywaldron opened this issue Jun 10, 2019 · 3 comments · Fixed by #98
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@aywaldron
Copy link
Contributor

Small sat missions use AOS transfer frames rather than TM transfer frames.

class AOSTransFrame(object):

  • Configuration of transfer frame also needs to be defined in sle_tlm.yaml
    https://github.com/NASA-AMMOS/AIT-DSN/blob/master/ait/dsn/sle/frames.py
  • TMTransFrame referenced in raf.py and rcf.py - these would need to be changed (also in ait_sle_bridge.py example)
  • RAF sends frame._data to telem socket in RAF._transfer_data_invoc_handler - needs to be changed either by sub-classing or explicitly overwriting self._handlers for that handler type (frame._data is filled in frame class in frames.py)
    tmf = frames.TMTransFrame(tm_data)
@kmarwah
Copy link
Contributor

kmarwah commented Jun 12, 2019

Hey, I'm working with the LunaH-Map team and I'm currently working on implementing this. It should be done in a few days or so. Can you please explain the changes required in RAF._transfer_data_invoc_handler in greater detail? Thanks!

@aywaldron
Copy link
Contributor Author

aywaldron commented Jun 12, 2019

Hi @kmarwah, that's great to hear! So the last two bullet points above are referring to the same thing, the last one is just providing detail. The code in RAF here

tmf = frames.TMTransFrame(tm_data)
and in RCF here
tmf = frames.TMTransFrame(tm_data)
uses the TMTransFrame. If you will be using RAF or RCF with the AOSTransFrame instead, then you will need a way to change the frame that the _transfer_data_invoc_handler uses, or write a new handler. It may make the most sense to add a parameter to the RAF/RCF classes for the type of transfer frame to use, which defaults to TMTransFrame, and which the handler then references (@MJJoyce any thoughts on that?)

@aywaldron
Copy link
Contributor Author

@kmarwah implemented AOS transfer frames using the Iris radio's ICD (see PR #69 for details). This implementation should be expanded to match the CCSDS's AOS spec, https://public.ccsds.org/Pubs/732x0b3e1.pdf

@aywaldron aywaldron self-assigned this Jul 17, 2019
@aywaldron aywaldron removed their assignment Jul 31, 2019
@aywaldron aywaldron modified the milestone: Sprint 1 Aug 13, 2019
@MJJoyce MJJoyce added enhancement New feature or request good first issue Good for newcomers labels Sep 5, 2019
MJJoyce added a commit that referenced this issue Apr 20, 2020
Issue #60: Implement AOS Transfer Frames per Spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
3 participants