[cherry-pick][indexer] Cherry-pick to v1.28.0-release branch: Fix indexer to compile for Rust 1.75 (#18490)
#18496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@stefan-mysten is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
pei-mysten
approved these changes
Jul 2, 2024
after-ephemera
approved these changes
Jul 2, 2024
|
Just FYI, pushed a commit and reverted it to re-kick the CI. |
|
you can rebase on top of the latest commit in the branch. I fixed the test in my PR |
## Description These changes ensure that brew can compile our code to release `sui` binary, and similarly, that `cargo install [..] sui --branch testnet` does not break. We need this to go with the testnet release today. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
stefan-mysten
force-pushed
the
cherry_pick_fix_indexer
branch
from
cd502d8 to
8ecab65
Compare
stefan-mysten
merged commit 08b5038
into
MystenLabs:releases/sui-v1.28.0-release
40 of 43 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes ensure that brew can compile our code to release
suibinary, and similarly, thatcargo install [..] sui --branch testnetdoes not break. We need this to go with the testnet release today.Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.