Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[indexer] Fix indexer to compile for Rust 1.75 #18490

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

stefan-mysten
Copy link
Contributor

Description

These changes ensure that brew can compile our code to release sui binary, and similarly, that cargo install [..] sui --branch testnet does not break. We need this to go with the testnet release today.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@stefan-mysten stefan-mysten requested a review from sadhansood July 2, 2024 15:42
Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 3:43pm

Copy link

vercel bot commented Jul 2, 2024

@stefan-mysten is attempting to deploy a commit to the Mysten Labs Team on Vercel.

A member of the Team first needs to authorize it.

@stefan-mysten stefan-mysten merged commit 3d5c377 into MystenLabs:main Jul 2, 2024
42 of 45 checks passed
@stefan-mysten stefan-mysten deleted the fix_indexer branch July 2, 2024 16:53
stefan-mysten added a commit to stefan-mysten/sui that referenced this pull request Jul 2, 2024
## Description 

These changes ensure that brew can compile our code to release `sui`
binary, and similarly, that `cargo install [..] sui --branch testnet`
does not break. We need this to go with the testnet release today.

## Test plan 

How did you test the new or updated feature?

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
stefan-mysten added a commit to stefan-mysten/sui that referenced this pull request Jul 2, 2024
## Description 

These changes ensure that brew can compile our code to release `sui`
binary, and similarly, that `cargo install [..] sui --branch testnet`
does not break. We need this to go with the testnet release today.

## Test plan 

How did you test the new or updated feature?

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
stefan-mysten added a commit that referenced this pull request Jul 2, 2024
…ndexer to compile for Rust 1.75 (#18490) (#18496)

## Description 

These changes ensure that brew can compile our code to release `sui`
binary, and similarly, that `cargo install [..] sui --branch testnet`
does not break. We need this to go with the testnet release today.

## Test plan 

How did you test the new or updated feature?

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
tx-tomcat pushed a commit to tx-tomcat/sui-network that referenced this pull request Jul 29, 2024
## Description 

These changes ensure that brew can compile our code to release `sui`
binary, and similarly, that `cargo install [..] sui --branch testnet`
does not break. We need this to go with the testnet release today.

## Test plan 

How did you test the new or updated feature?

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants