-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Add more Rector rules #1372
Conversation
f189307
to
620091d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've struggled to find decent documentation. What I've found has been very sparse. Where are you getting your info from?
->withSets([ | ||
// Rector sets | ||
|
||
LevelSetList::UP_TO_PHP_73, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are these documented? I can't find it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/rectorphp/rector/blob/main/src/Set/ValueObject/LevelSetList.php and https://github.com/rectorphp/rector/blob/main/config/set/level/up-to-php73.php etc. Basically, the LevelSetList::UP_TO_PHP_*
set lists are about raising the PHP language level to the corresponding PHP version.
config/rector.php
Outdated
// PHPUnit sets | ||
|
||
PHPUnitSetList::PHPUNIT_90, | ||
// PHPUnitSetList::PHPUNIT_100, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Mostly from reading the source code after clicking on the method/constant/class in the configuration file. Also, I copy from the configuration files from other projects, e.g. https://github.com/FriendsOfTYPO3/tea/blob/main/rector.php (that also uses some TYPO3-specific rulesets). |
620091d
to
432deb0
Compare
No description provided.