Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Add more Rector rules #771

Merged
merged 1 commit into from
Nov 17, 2024
Merged

[TASK] Add more Rector rules #771

merged 1 commit into from
Nov 17, 2024

Conversation

oliverklee
Copy link
Contributor

@oliverklee oliverklee commented Nov 10, 2024

This change is almost identical to the corresponding change for Emogrifier. The only differences are that we're using PHPUnit 8 here, not PHPUnit 9, and PHP 7.2, not 7.3.

github-actions[bot]

This comment was marked as off-topic.

@coveralls
Copy link

coveralls commented Nov 10, 2024

Coverage Status

coverage: 38.583%. remained the same
when pulling 19d58f3 on task/rector-config
into c7e6118 on main.

@oliverklee oliverklee force-pushed the task/rector-config branch 2 times, most recently from 27a3930 to 0b2e564 Compare November 16, 2024 17:44
@oliverklee oliverklee marked this pull request as ready for review November 17, 2024 19:00
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JakeQZ JakeQZ merged commit 3eb42ce into main Nov 17, 2024
21 checks passed
@JakeQZ JakeQZ deleted the task/rector-config branch November 17, 2024 19:05
oliverklee added a commit that referenced this pull request Nov 17, 2024
JakeQZ pushed a commit that referenced this pull request Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants