Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update Electron dependancy (LEGACY) #3363

Closed
wants to merge 41 commits into from
Closed

Conversation

409H
Copy link
Collaborator

@409H 409H commented Jul 14, 2020

[CH6358]

🎉 🎉 🎉

WIP:

  • Fix tsc errors
  • Test builds are successful
  • Test functionality is not broken

Description

  • Update Electron to newer version
  • Patch Electron API usage for newer version

Changes

  • Updated dependancy for electron
  • Updated electron API usage within electron-app/

Quality Assurance

  • The branch name is in lowercase-kebab-case with no prefix (unless it was created from Clubhouse)
  • The base branch is develop or gau (no nested branches)
  • This is related to a maximum of one Clubhouse story or GitHub issue
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types)
  • If code is copied from existing directories, there is an explanation of why this is necesary in the description/changes, and all copying is done in separate commits to make them easy to filter out
  • If your code adds new text to the UI, the added text is translatable

@FrederikBolding FrederikBolding force-pushed the security/update_electron branch from de9e290 to f24b72f Compare August 20, 2020 09:24
@Mrtenz Mrtenz force-pushed the security/update_electron branch from 0d4d642 to d33da1f Compare January 16, 2021 23:52
@stale
Copy link

stale bot commented Jun 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 26, 2021
@stale stale bot closed this Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants