Bad checksum validation in "Add custom token" for RSK (or non ETH chains)

[alepc253]

Description of Issue

"Add custom token" has an invalid address checksum validation for non ETH networks (RSK in this case)

What exactly were you doing when you encountered this issue?

1- Connect to RSK Mainnet
2- "Add custom token"
3- Put 0xE700691Da7B9851F2F35f8b8182C69C53ccad9DB as address
4- Check "Not a valid address" message

How were you accessing your wallet?

It doesn't matter in this case

Description of Your Machine

• MyCrypto Desktop Application
• MyCrypto Version Number: 1.7.10

Console Logs / Screenshots

[Mrtenz]

Thanks for the report. Is this the case for all non-Ethereum networks, or just RSK? IIRC, RSK uses a different way to generate address checksums, so it's possible that the function to validate the address isn't using that for the custom token functionality.

[alepc253]

Hi @Mrtenz, TBH I didn't try other networks but it should fail for every network that implements EIP1191 or with a different checksum calculation

[Mrtenz]

Ok, thank you. I will investigate further and push a fix soon. You might be able to get around this by using lowercase addresses for now (though I haven't tested this).

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Mrtenz]

This is currently blocked by #3363 due to Node.js incompatibilities. Once that PR is merged, I'll make a PR for this issue.

[Mrtenz]

I figured out a solution, it should be included in the next release of the legacy app.