Preload entrypoint #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like very useful improvement. Can I help somehow to get it merged? |
|
bump |
|
Happy to make any changes! |
|
bump |
|
bump - Happy to make any changes! |
thijskramer
requested changes
May 22, 2023
gone
force-pushed
the
preload_entrypoint
branch
2 times, most recently
from
779ced8 to
d41e339
Compare
|
Rebased, and updated to use the logic in #52 for preloading |
|
Looks good to me! I'll merge it, and I'll create a new release with this feature in it next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an entry point that I'd like to preload before use and would like to not block render to load the css for it. This adds a top level tag that will drop the preload statements into the dom for a given vite asset