Use staticfiles.storage to generate URLs

[blighj]

For Vite production mode it seems like it would be useful to use django staticfiles.storage.staticfiles_storage.url method, if staticfiles is installed,
similar to how Django's own static template tag works. https://github.com/django/django/blob/0dd29209091280ccf34e07c9468746c396b7778e/django/templatetags/static.py

[ajslater]

This change should let people use the WHITENOISE_KEEP_ONLY_HASHED_FILES = True option if they like.

One suggestion: I'd change line 59 of this PR to:

DJANGO_VITE_STATIC_ROOT / staticfiles_storage.stored_name("manifest.json"),

as a sensible default.

[ajslater]

Sadly WHITENOISE_KEEP_ONLY_HASHED_FILES = True is only useful in the case where everything is one big main module. If you have chunks, then javascript will be generating those module links directly in the browser and it will have no access to the django staticfiles lookup.

However, even in that case a large amount of code, likely the majority, will still be contained in main.js and this patch would still give a speedup to the compressed main.<vitehash>.<whitenoisehash>.js.br

[blighj]

django 4.2 will add support for processing import statements in javascript files when using ManifestStaticFilesStorage.
This MR is now the last piece of the jigsaw, once django-vite supports staticfiles at the entry point, you will be able to set far future cache headers on all your javascript files without having to worry about cache busting issues when updating your code.

django.contrib.staticfiles

• ManifestStaticFilesStorage now replaces paths to JavaScript modules in import and export statements with their hashed counterparts.

[thijskramer]

@blighj this looks very promising to me! Could you rebase your PR? Then I'll take a look in the next few days and try to merge this PR.

[blighj]

@thijskramer After a bit of messing, I've rebased that now.

[devwaseem]

If you have chunks, then javascript will be generating those module links directly in the browser and it will have no access to the django staticfiles lookup.

I'm facing the same problem. I'm using s3 as static file storage and the URLs are not resolved correctly for dynamic imports. I guess this PR solves the problem.

[asg86260]

Is there a planned next release to include this?

[thijskramer]

I’ll try to make a release within the next few days.

…

On Wed, 24 May 2023 at 19:37, Andrew Graham ***@***.***> wrote: Is there a planned next release to include this? — Reply to this email directly, view it on GitHub <#52 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJXH4ZXALXP5COHH26VH7DXHZBN5ANCNFSM563GNUPA> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[petrprikryl]

Btw. this will no longer work:

django-vite/README.md

Line 224 in 2b5f899

DJANGO_VITE_STATIC_URL_PREFIX = 'bundler'

Due https://github.com/MrBin99/django-vite/pull/52/files#diff-340facb9cc1393cad64ce6b5408114ea99338657f8386e4a0d99e97c4b01e2d8R459

urljoin("bundler", "entry.js")
>  'entry.js'

urljoin("bundler/", "entry.js")
> 'bundler/entry.js'