added newsletter to index page template #9292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fessehaye! Sorry for the request for re-review, the wagtail CI seemed to be having issues with migrations as initially I set the base branch to main by mistake. After updating it to be based off PNI-2022, it appears the jobs were still set to run off main as the tests were failing. |
fessehaye
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to sample test page:
Related PRs/issues: #9109
This PR adds the newsletter callout box to the editorial content index page for PNI
Screenshot
Checklist
Tests
Is the code I'm adding covered by tests?Changes in Models:
Did I update or add new fake data?Did I squash my migration?Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?Documentation:
Is my code documented?Did I update the READMEs or wagtail documentation?