Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PNI] - Editorial Content “Index” Page [Frontend] #9109

Closed
5 of 9 tasks
fessehaye opened this issue Jul 14, 2022 · 10 comments
Closed
5 of 9 tasks

[PNI] - Editorial Content “Index” Page [Frontend] #9109

fessehaye opened this issue Jul 14, 2022 · 10 comments
Assignees
Labels
buyer's guide 🛍 Issues related to the buyer's guide engineering frontend p1 this work should get done first product Drive Products Forward
Milestone

Comments

@fessehaye
Copy link
Contributor

fessehaye commented Jul 14, 2022

Desktop comp
Mobile comp
Tablet comp

image

Editorial Content “Index” Page

Dev Tasks:

  • Create Grid Layout for Editorial Content “Index” Page
  • Style article cards
  • include newsletter CTA block
  • include popular article blocks (Ticket for this template pending)
  • nclude callout CTA (Ticket for this template pending)
  • inlcude mobile and tablet styling

Acceptance Criteria:

  • Editorial Content “Index” Page is styled properly
  • Editorial Content “Index” Page has mobile and tablet responsive styling
  • Newsletter CTA only appears on default page (All Articles) (Ticket for this different page types pending)
@fessehaye fessehaye added engineering buyer's guide 🛍 Issues related to the buyer's guide frontend labels Jul 14, 2022
@fessehaye fessehaye added this to the PNI Dev 2022 milestone Jul 14, 2022
@fessehaye
Copy link
Contributor Author

Popular Articles are not as high priority as the rest!

@fessehaye fessehaye added the p1 this work should get done first label Jul 18, 2022
@tbrlpld tbrlpld assigned tbrlpld and unassigned tbrlpld Jul 18, 2022
@beccaklam
Copy link

This ticket looks fine but again we need to finalize the styling first which Nancy is doing this sprint so I'm not sure this work will be ready to start until Aug 2 @nancyt1 @kristinashu

@tbrlpld
Copy link
Collaborator

tbrlpld commented Jul 19, 2022

@beccaklam This is not in our sprint. So start with the next sprint (Aug 2) should be fine.

@cdanfon
Copy link

cdanfon commented Sep 7, 2022

Hey @danielfmiranda I can see that this ticket has been in Internal review for 8 days, can I get an update on it please? Thanks!

@cdanfon
Copy link

cdanfon commented Sep 8, 2022

He @danielfmiranda I had a look at this on staging. A couple of things:

  • The background on the Figma file has some shapes that don't appear on the page - see attachment Make kickoff plan #1.

  • The images appear to be stretched - see attachment Gather benchmarks #2.

  • The title on the Figma file reads as 'All Articles', the title on staging read as 'Articles'

  • Underneath the title we have some filtering options that are not present on the staging site - see attachment Prepare wireframes #3

Any questions let me know!

attachment_1.png
attachment_2.png
attachment_3.png

@danielfmiranda
Copy link
Collaborator

Hi @cdanfon!

Apologies for any confusion, the ask of this ticket was just to create the grid layout + cards that are going to be used on this index page.

The filtering and shapes in the background are taken care of in other tickets. tagging @fessehaye to confirm

Also, regarding the title of the page, this can be updated in the CMS

However, the stretched images does seem to be an issue. Can you please send me the file that you used to recreate this so I can take a look at the dimensions?

Thanks!

@fessehaye
Copy link
Contributor Author

fessehaye commented Sep 8, 2022

Filters and background pattern are not apart of this ticket. Patterns are a p3 ticket and are probably last on the to-do list. The background pattern is also not exclusive to this page and will be used on the whole PNI site!

@danielfmiranda
Copy link
Collaborator

Have created #9338 to solve the image issue!

@cdanfon
Copy link

cdanfon commented Sep 9, 2022

Hey @fessehaye @danielfmiranda thanks for explaining.

The Acceptance Criteria in this ticket created confusion as it was asking to check whether Editorial Content “Index” Page is styled properly

Looking at the Figma files the ticket doesn't match the styling.

Now that you've explained makes sense, but let's try to write ACs as good as we can :)

@cdanfon cdanfon closed this as completed Sep 9, 2022
@cdanfon cdanfon reopened this Sep 9, 2022
@cdanfon
Copy link

cdanfon commented Sep 9, 2022

Moving this ticket to "Closed" taking into account that the image issue will be fixed via #9338

@cdanfon cdanfon closed this as completed Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buyer's guide 🛍 Issues related to the buyer's guide engineering frontend p1 this work should get done first product Drive Products Forward
Projects
None yet
Development

No branches or pull requests

6 participants