-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PNI] - Editorial Content “Index” Page [Frontend] #9109
Comments
Popular Articles are not as high priority as the rest! |
This ticket looks fine but again we need to finalize the styling first which Nancy is doing this sprint so I'm not sure this work will be ready to start until Aug 2 @nancyt1 @kristinashu |
@beccaklam This is not in our sprint. So start with the next sprint (Aug 2) should be fine. |
Hey @danielfmiranda I can see that this ticket has been in Internal review for 8 days, can I get an update on it please? Thanks! |
He @danielfmiranda I had a look at this on staging. A couple of things:
Any questions let me know! |
Hi @cdanfon! Apologies for any confusion, the ask of this ticket was just to create the grid layout + cards that are going to be used on this index page. The filtering and shapes in the background are taken care of in other tickets. tagging @fessehaye to confirm Also, regarding the title of the page, this can be updated in the CMS However, the stretched images does seem to be an issue. Can you please send me the file that you used to recreate this so I can take a look at the dimensions? Thanks! |
Filters and background pattern are not apart of this ticket. Patterns are a p3 ticket and are probably last on the to-do list. The background pattern is also not exclusive to this page and will be used on the whole PNI site! |
Have created #9338 to solve the image issue! |
Hey @fessehaye @danielfmiranda thanks for explaining. The Acceptance Criteria in this ticket created confusion as it was asking to check whether Editorial Content “Index” Page is styled properly Looking at the Figma files the ticket doesn't match the styling. Now that you've explained makes sense, but let's try to write ACs as good as we can :) |
Moving this ticket to "Closed" taking into account that the image issue will be fixed via #9338 |
Desktop comp
Mobile comp
Tablet comp
Editorial Content “Index” Page
Dev Tasks:
include popular article blocks(Ticket for this template pending)nclude callout CTA(Ticket for this template pending)Acceptance Criteria:
Newsletter CTA only appears on default page (All Articles)(Ticket for this different page types pending)The text was updated successfully, but these errors were encountered: