9109 editorial index page #9252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfmiranda
commented
Aug 29, 2022
| @@ -206,6 +206,8 @@ class Meta: | |||
|
|
|||
| title = Faker('sentence') | |||
| hero_image = SubFactory(ImageFactory) | |||
| first_published_at = Faker('past_datetime', start_date='-30d', tzinfo=timezone.utc) | |||
There was a problem hiding this comment.
Just some updates to the factory to make sure articles have a published date and description
danielfmiranda
changed the title
fessehaye
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to sample test page:
Related PRs/issues: #9109
Screenshots
Article Page Cards Desktop:
Article Page Cards Tablet:
Article Page Cards Mobile:
Product Update Cards Desktop:
Product Update Cards Tablet:
Product Update Cards Mobile:
Checklist
Tests
[ ] Is the code I'm adding covered by tests?Changes in Models:
[ ] Did I update or add new fake data?[ ] Did I squash my migration?[ ] Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?Documentation:
[ ] Is my code documented?[ ] Did I update the READMEs or wagtail documentation?