-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AppInstallPage #12122
Add AppInstallPage #12122
Conversation
network-api/networkapi/wagtailpages/templates/wagtailpages/campaign_page.html
Show resolved
Hide resolved
network-api/networkapi/wagtailpages/templates/wagtailpages/campaign_page.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So amazing! Thank you @danielfmiranda for getting all the little details of this right!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work @danielfmiranda ! 🔥
@danielfmiranda While reviewing the app, I noticed two issues regarding buttons: 1. Mobile view buttons width 2. When using tab for navigation and onFocus, the text turns width on the buttons The onFocus styling should be similar as the onHover, which turns the button background color black. |
Great catches @simont-cr! My latest commit to this PR updates the width and focus state of the buttons 👍 Whenever you find a free moment, can you please take another look at the review apps and approve the PR if everything looks OK? Thanks! |
Thanks for calling that out @kristinashu! I have created https://mozilla-hub.atlassian.net/browse/TP1-368 to investigate 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tabbing through the buttons no longer cause issues and mobile btns are now similar width as expected, looking good, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @danielfmiranda !
➤ Simon Acosta Torres commented: PR has already been merged. |
Description
Link to sample test Youtube page: https://foundation-s-tiktok-pag-1mbxqc.mofostaging.net/en/youtuberegrets/
Link to sample test TikTok page: https://foundation-s-tiktok-pag-1mbxqc.mofostaging.net/en/tiktok/
Link to Figma File: Figma
Related PR: #12036
This PR introduces a new page model
AppInstallPage
which is planned to be used on the upcoming TikTok Reporter App page, and to also recreate the Youtube Regrets Reporter Extension page.The ask for this page was to have the hero section of the regrets reporter page (with some minor design changes), and the "body/cta" section of a campaign page.
To achieve this I made the
AppInstallPage
inherit from our existingCampaignPage
model, so they can share the samebody
/cta
fields.I also had
app_install_page.html
extendcampaign_page.html
, with some minor updates to accommodate requests from design.Screenshots
Figma Mockup:
Review App:
Please note that:
┆Issue is synchronized with this Jira Story