-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PNI Playwright tests #11765
Fix PNI Playwright tests #11765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mmmavis, thanks for this! It's working well LGTM 🚀
Another thing that I noticed here is that |
Ticket to clean up |
@jhonatan-lopes thanks for the suggestions and filing follow-up ticket to make our dev setup more concrete! |
Related #9373
This PR enables existing Playwright tests for PNI search related functionalities by fixing broken code and breaking code into individual tests using test hooks.
File is relocated under a new folder
pni
and renamed intosearch.spec.js
To test locally
docker-compose up
on one tabpackage.json
, update line 52 to"playwright:integration": "wait-on -i 3000 -t 120000 -v http://127.0.0.1:8000/cms && playwright test ./tests/integration/pni"
so you can skip all other tests unrelated to PNI searchnpm run playwright:integration