Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNI - Fix PNI Playwright tests #9373

Closed
6 tasks
danielfmiranda opened this issue Sep 16, 2022 · 2 comments
Closed
6 tasks

PNI - Fix PNI Playwright tests #9373

danielfmiranda opened this issue Sep 16, 2022 · 2 comments
Assignees
Labels
buyer's guide 🛍 Issues related to the buyer's guide code cleanup engineering maintain Maintain digital systems purge Issues with this label will be purged from our backlog unless there is a very good reason.

Comments

@danielfmiranda
Copy link
Collaborator

danielfmiranda commented Sep 16, 2022

At the moment, the PNI search test for playwright is failing due to the animations that load in the products. This is causing a random number to be returned in the assert statements, we should figure out a way to get a consistent number to test against.

We should break down the existing test into smaller tests so it will be easier to debug using test hooks https://playwright.dev/docs/writing-tests#using-test-hooks. Right now we have one test with multiple places that can error which makes it hard to know what is causing the issue.

Viewing playwright documentation should be done before attempting this ticket: https://playwright.dev/docs/intro

Dev Tasks:

  • Remove fixme
  • Fix the PNI search test
  • move PNI search to its own file
  • Break PNI search to multiple smaller tests with test hooks
  • Created a plan for making PNI tests for the rest of the pages (Article, Products)
  • Add discussion on how to maintain and extend playwright tests for foundation site
@kristinashu kristinashu added the buyer's guide 🛍 Issues related to the buyer's guide label Oct 21, 2022
@tbrlpld tbrlpld added the maintain Maintain digital systems label Nov 2, 2022
@fessehaye fessehaye self-assigned this Nov 25, 2022
@cdanfon
Copy link

cdanfon commented Jan 9, 2023

@fessehaye Can you please add your thoughts about this in the ticket to kickstart the discussion? Thanks!

@mmmavis
Copy link
Collaborator

mmmavis commented Jan 25, 2024

PR has been merged into main. Closing!

@mmmavis mmmavis closed this as completed Jan 25, 2024
@simont-cr simont-cr added the purge Issues with this label will be purged from our backlog unless there is a very good reason. label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buyer's guide 🛍 Issues related to the buyer's guide code cleanup engineering maintain Maintain digital systems purge Issues with this label will be purged from our backlog unless there is a very good reason.
Projects
None yet
Development

No branches or pull requests

7 participants