Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to keep old package versions with local repo #668

Merged
merged 8 commits into from
Feb 20, 2022

Conversation

JeWe37
Copy link
Contributor

@JeWe37 JeWe37 commented Feb 1, 2022

Motivation: I want to use the local repository functionality to keep a record of all versions of AUR packages that I have installed, as there is no equivalent of say the ALA. The git versions of the PKGBUILDs have the drawback of depending on potentially dead external resources. I often find myself clearing the regular cache though and it is far less feasible to centralize it(say for faster installs of AUR packages already installed on my PC on my Laptop).

There might very well be further applications for this that I have not thought of but this is my use case.

Changes: Therefore I would like to keep a record of the packages in the local repository, however this was prevented by the -R option being set on repo-add. This PR adds a simple set of CLI and config options to optionally disable that flag.

@Morganamilo
Copy link
Owner

Looks good but don't know about the name. How about KeepDbPackages? KeepRepoPackages?

@JeWe37
Copy link
Contributor Author

JeWe37 commented Feb 5, 2022

Can't say I have strong opinions on the naming, KeepDbPackages seems slightly off since the DB is the part that isn't kept, so how about I go with KeepRepoPackages? Any preferences as to what I should do with the command line arguments or keep those as-is?

@Morganamilo
Copy link
Owner

KeepRepoPackages slightly conflicts because most user's will probably not realise it's to do with local repos. KeepLocalRepoPackages would be too long too.

Ideally the config and flag names would be the same. Some times they's a bit different when it's useful for the flag to be short (like --aur) but then lacks a bit of context.

Not gonna bike shed forever though KeepRepoPackages is fine.

Actually KeepRepoCache may be better actually. It's up to you which sounds better.

@JeWe37
Copy link
Contributor Author

JeWe37 commented Feb 16, 2022

KeepRepoCache it is. Alongside --keeprepocache and --nokeeprepocache then. I should be able to find the time to finish this off this weekend. I saw there were some changes with a new command interface but that shouldn't be a big deal.

@JeWe37
Copy link
Contributor Author

JeWe37 commented Feb 18, 2022

Alright this should be it. Renamed and using the new command line system.

man/paru.8 Outdated Show resolved Hide resolved
@Morganamilo Morganamilo merged commit fae9829 into Morganamilo:master Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants