Option to keep old package versions with local repo (#668)

* Option to not remove old packages in local repo

* Add command line option and docs.

* Add completions

* Fix wrong option setting

* remove test files

* Renamed option to KeepRepoCache

* fix copy paste error

completions/bash

@@ -76,7 +76,7 @@ _paru() {
            nouseask savechanges nosavechanges combinedupgrade nocombinedupgrade
            batchinstall nobatchinstall provides noprovides devel nodevel develsuffixes
            sudoloop nosudoloop bottomup topdown newsonupgrade bat batflags chroot nochroot
-           sign nosign signdb nosigndb
+           sign nosign keeprepocache nokeeprepocache signdb nosigndb
            localrepo review skipreview' 'b d h q r v a')
 
   show=('news stats' 'w s')

completions/fish

@@ -240,6 +240,8 @@ complete -c $progname -n "not $noopt" -l chroot -d 'Build packages in a chroot'
 complete -c $progname -n "not $noopt" -l nochroot -d "Don't build packages in a chroot" -f
 complete -c $progname -n "not $noopt" -l sign -d 'Sign packages with gpg' -f
 complete -c $progname -n "not $noopt" -l nosign -d "Don't sign packages with gpg" -f
+complete -c $progname -n "not $noopt" -l keeprepocache -d 'Keep old versions of packages with local repo' -f
+complete -c $progname -n "not $noopt" -l nokeeprepocache -d "Don't keep old versions of packages with local repo" -f
 complete -c $progname -n "not $noopt" -l signdb -d 'Sign databases with gpg' -f
 complete -c $progname -n "not $noopt" -l nosigndb -d "Don't sign databases with gpg" -f
 complete -c $progname -n "not $noopt" -l localrepo -d 'Build packages in a local repo' -f

completions/zsh

@@ -106,6 +106,8 @@ _pacman_opts_common=(
 	"--nochroot[Don't build packages in a chroot]"
 	'--sign[Sign packages with gpg]'
 	"--nosign[Don't sign packages with gpg]"
+	'--keeprepocache[Keep old versions of packages with local repo]'
+	"--nokeeprepocache[Don't keep old versions of packages with local repo]"
 	'--signdb[Sign databases with gpg]'
 	"--nosigndb[Don't sign databases with gpg]"
 	'--localrepo[Build packages in a local repo]'

man/paru.8

@@ -591,6 +591,15 @@ Sign packages with gpg. Optionally indicate which key to sign with.
 .B \-\-nosign
 Don't sign package with gpg.
 
+.TP
+.B \-\-keeprepocache
+Normally upon AUR packages getting updated the old versions will be removed from the local repo.
+This option disables that behavior, keeping the both all versions and only updating the DB.
+
+.TP
+.B \-\-nokeeprepocache
+Don't keep old packages.
+
 .TP
 .B \-\-signdb [= key]
 Sign databases with gpg. Optionally indicate which key to sign with.

man/paru.conf.5

@@ -219,6 +219,11 @@ Sign packages with gpg. Optionally indicate which key to sign with.
 .B SignDb [= key]
 Sign databases with gpg. Optionally indicate which key to sign with.
 
+.TP
+.B KeepRepoCache
+Normally upon AUR packages getting updated the old versions will be removed from the local repo.
+This option disables that behavior, keeping the both all versions and only updating the DB.
+
 .TP
 .B SkipReview
 Skip the review process.

paru.conf

@@ -28,6 +28,7 @@ DevelSuffixes = -git -cvs -svn -bzr -darcs -always -hg
 #Chroot
 #Sign
 #SignDb
+#KeepRepoCache
 
 #
 # Binary OPTIONS

src/command_line.rs

@@ -317,6 +317,8 @@ impl Config {
                     Err(_) => Sign::Yes,
                 }
             }
+            Arg::Long("nokeeprepocache") => self.keep_repo_cache = false,
+            Arg::Long("keeprepocache") => self.keep_repo_cache = true,
             Arg::Long("signdb") => {
                 self.sign_db = match value {
                     Ok(k) => Sign::Key(k.to_string()),

src/config.rs

@@ -391,6 +391,7 @@ pub struct Config {
     pub news_on_upgrade: bool,
     pub comments: bool,
     pub sign: Sign,
+    pub keep_repo_cache: bool,
     pub sign_db: Sign,
 
     pub pre_build_command: Option<String>,
@@ -870,6 +871,7 @@ impl Config {
                     None => Sign::Yes,
                 }
             }
+            "KeepRepoCache" => self.keep_repo_cache = true,
             "SignDb" => {
                 self.sign_db = match value {
                     Some(v) => Sign::Key(v.to_string()),

src/repo.rs

@@ -55,7 +55,12 @@ pub fn add<P: AsRef<Path>, S: AsRef<OsStr>>(
         .collect::<Vec<_>>();
 
     let mut cmd = Command::new("repo-add");
-    cmd.arg("-R").arg(file).args(pkgs);
+
+    if !config.keep_repo_cache {
+        cmd.arg("-R");
+    }
+
+    cmd.arg(file).args(pkgs);
 
     if config.sign_db != Sign::No {
         cmd.arg("-s");