Mining Skillchip #756
Merged
Mining Skillchip #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The basic functionality of the new Shaft Miner skillchip. Includes a new list function.
Expands upon the list of pointable entities. Adds the skillchip to the library vending machine.
Skillchip now a quirk rather than an inherent trait to miners. Adds more lines. Updates radio cooldown to be randomized.
|
Suggestions very open for lines. |
|
pointing at gold spams we're rich right |
|
Mining mob lines are done
Finished lines for weapons and materials. Almost done.
More items, almost done. I shall finish what couldn't be!
Finally done with these, now it's ready for review.
monkestation/code/modules/library/skill_learning/job_skillchips/shaft_miner.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/library/skill_learning/job_skillchips/shaft_miner.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/library/skill_learning/job_skillchips/shaft_miner.dm
Show resolved
Hide resolved
Moves the list from a global list to a static skillchip list. Adds notice spans.
This was referenced Jan 1, 2024
Closed
Closed
Closed
This was referenced Jan 11, 2024
This was referenced Jan 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds a new neutral (0 point) quirk, "Miner Training", which gives the holder a skillchip allowing them to call out anything mining related they see when they point at it.
It's literally a Deep Rock Galactic reference.
Based off of tgstation/tgstation#72238
Made the suggested changes that contributors had there.
I have very likely missed a number of objects that miners often interact with, but it is very easy to add new ones.
2023-12-19.08-33-45.mp4
Why It's Good For The Game
Meme value aside, this is actually surprisingly more useful than you might think.
Miners are constantly seen as silent and can die without anyone ever realizing it, so giving them a method to easily call out over the radio lets Cargo know if they are alive or not.
And if they go dead silent, they might actually send someone to go searching!
Changelog
🆑
add: Adds "Miner Training" as a Neutral Quirk
/:cl: