Phobia regex should not be a global expression #5008
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
While developing a new quirk that used the phobia system, I noticed that I was able to bypass the phobia regex.
Looking further into it, I found that the phobia regex is marked as a global expression with the
g
. Quoting the DM Reference on theg
flag:This clearly isn't the behavior we want for handling text in phobias! Thus, this PR removes the
g
flag from phobia regexes.Why It's Good For The Game
Bug fixes give me good coder points. :D
Changelog
🆑MichiRecRoom
fix: Word phobias should always apply now, rather than occasionally being missed.
/:cl: