Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming viro subtypes and fixing disease severities and maintence panels (AKA a bunch of fixes for viro at this point.) #4931

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Gw0sty
Copy link
Collaborator

@Gw0sty Gw0sty commented Jan 17, 2025

About The Pull Request

  • Renames all mentions of disease/advanced into disease/acute

  • Salvages Old viro code to enable disease severities to be set automatically
    Triggered when most disease sources are created.
    Immunity scanners, disease analyzers, or disease state analyzers are used

  • Delightful effect is now considered positive.

  • Viro machines (Disease analyzer, Incubator, and centrifuge) now have maintenance panels and can be upgraded with a basic RPED and deconstructed with a crowbar.

  • Porokeratosis Acanthus and Epidermolysis Bullosa will no longer appear.

  • Disease incubators now are built with 4 scanning modules, rather than 2.

Why It's Good For The Game

Refactoring disease/advanced

Old diseases had/have the subtype of disease/advance, new diseases have the current subtype of disease/advanced The one-letter difference between the two can easily cause confusion and make the code difficult to work with for potential mix-ups. The change to disease/acute at the least has helped me greatly in this pr.

Severities are now automatic rather than manually defined

With disease severities now set automatically for most if not all instances I can find, Health huds should properly be displaying the severity of the infectee's disease. Knowing if concerned should be given or if it can be overlooked by a doctor

Delightful is a helpful symptoms

Delightful is a mostly positive effect, much like tox comp or regen coma when too strong or weak it becomes negative.

Maintence panels included

Viro machines have been given maintenance panels. For a job that greatly benefits from having parts to complete their work not having maintenance panels seriously hurt their processes.

Removing nonfunctional symptoms for now

Epidermolysis Bullosa (Butterfly skin) and Porokeratosis Acanthus were removed from the viro pool because the symptoms do not trigger functionally.

Incubators now are faster

Incubators are now made with four scanning modules. Functionally this means mutation chance goes from 10% and 40% at max to 20% and 80% max. Recently we've seen the pace of rounds speed up. And viro slows down. Most notably with emergency shuttles now being voted on at the one-hour-thirty mark. And my PR #4061, which took away easy high tier scanning modules for virologists.
In my experience, you'll finish up diseases a good portion of the time while the shuttle arrives.
This makes Viro less reliant on other departments for a half-decent QOL if mining or science fails to do their job. While making cross-departmental cooperation between those departments more influential.
In addition the waiting period for your virus's to mutate are the least interesting part of virology.

Changelog

🆑
add: Maintence panels and sprites to viro machines
del: Removed Epidermolysis Bullosa and Porokeratosis Acanthus from appearing
balance: Delightful effect is now considered a helpful effect
balance: Viro's incubators are now twice as fast overall (10%:40% to 20%:80%)
fix: Disease severities and hud states will now properly set
code: Changed the subtype for diseases
/:cl:

@Gw0sty Gw0sty added the do not merge don't merge this ffs label Jan 17, 2025
@Gw0sty Gw0sty marked this pull request as ready for review January 17, 2025 06:01
@Gw0sty Gw0sty removed the do not merge don't merge this ffs label Jan 17, 2025
@Gw0sty Gw0sty changed the title [DNM] Renaming viro subtypes Renaming viro subtypes Jan 17, 2025
@Kitsunemitsu Kitsunemitsu added Tweak change a thing to work a little different QoL improves quality of life labels Jan 17, 2025
@Gw0sty Gw0sty changed the title Renaming viro subtypes Renaming viro subtypes and fixing disease severities Jan 20, 2025
@Gw0sty Gw0sty added the testmerge only don't merge this, this is only for testmerging, i.e temporary fixes label Jan 20, 2025
@Gw0sty Gw0sty changed the title Renaming viro subtypes and fixing disease severities Renaming viro subtypes and fixing disease severities and maintence panels (AKA a bunch of fixes for viro at this point.) Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance perfectly balanced as all things should be QoL improves quality of life testmerge only don't merge this, this is only for testmerging, i.e temporary fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants