-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming viro subtypes and fixing disease severities and maintence panels (AKA a bunch of fixes for viro at this point.) #4931
Open
Gw0sty
wants to merge
12
commits into
Monkestation:master
Choose a base branch
from
Gw0sty:advance-advanced
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kitsunemitsu
added
Tweak
change a thing to work a little different
QoL
improves quality of life
labels
Jan 17, 2025
Gw0sty
changed the title
Renaming viro subtypes
Renaming viro subtypes and fixing disease severities
Jan 20, 2025
Gw0sty
added
the
testmerge only
don't merge this, this is only for testmerging, i.e temporary fixes
label
Jan 20, 2025
Gw0sty
changed the title
Renaming viro subtypes and fixing disease severities
Renaming viro subtypes and fixing disease severities and maintence panels (AKA a bunch of fixes for viro at this point.)
Jan 21, 2025
Gw0sty
added
Balance
perfectly balanced as all things should be
and removed
Tweak
change a thing to work a little different
labels
Jan 21, 2025
This was referenced Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Balance
perfectly balanced as all things should be
QoL
improves quality of life
testmerge only
don't merge this, this is only for testmerging, i.e temporary fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Renames all mentions of
disease/advanced
intodisease/acute
Salvages Old viro code to enable disease severities to be set automatically
Triggered when most disease sources are created.
Immunity scanners, disease analyzers, or disease state analyzers are used
Delightful effect is now considered positive.
Viro machines (Disease analyzer, Incubator, and centrifuge) now have maintenance panels and can be upgraded with a basic RPED and deconstructed with a crowbar.
Porokeratosis Acanthus and Epidermolysis Bullosa will no longer appear.
Disease incubators now are built with 4 scanning modules, rather than 2.
Why It's Good For The Game
Refactoring
disease/advanced
Old diseases had/have the subtype of
disease/advance
, new diseases have the current subtype ofdisease/advanced
The one-letter difference between the two can easily cause confusion and make the code difficult to work with for potential mix-ups. The change todisease/acute
at the least has helped me greatly in this pr.Severities are now automatic rather than manually defined
With disease severities now set automatically for most if not all instances I can find, Health huds should properly be displaying the severity of the infectee's disease. Knowing if concerned should be given or if it can be overlooked by a doctor
Delightful is a helpful symptoms
Delightful is a mostly positive effect, much like tox comp or regen coma when too strong or weak it becomes negative.
Maintence panels included
Viro machines have been given maintenance panels. For a job that greatly benefits from having parts to complete their work not having maintenance panels seriously hurt their processes.
Removing nonfunctional symptoms for now
Epidermolysis Bullosa (Butterfly skin) and Porokeratosis Acanthus were removed from the viro pool because the symptoms do not trigger functionally.
Incubators now are faster
Incubators are now made with four scanning modules. Functionally this means mutation chance goes from 10% and 40% at max to 20% and 80% max. Recently we've seen the pace of rounds speed up. And viro slows down. Most notably with emergency shuttles now being voted on at the one-hour-thirty mark. And my PR #4061, which took away easy high tier scanning modules for virologists.
In my experience, you'll finish up diseases a good portion of the time while the shuttle arrives.
This makes Viro less reliant on other departments for a half-decent QOL if mining or science fails to do their job. While making cross-departmental cooperation between those departments more influential.
In addition the waiting period for your virus's to mutate are the least interesting part of virology.
Changelog
🆑
add: Maintence panels and sprites to viro machines
del: Removed Epidermolysis Bullosa and Porokeratosis Acanthus from appearing
balance: Delightful effect is now considered a helpful effect
balance: Viro's incubators are now twice as fast overall (10%:40% to 20%:80%)
fix: Disease severities and hud states will now properly set
code: Changed the subtype for diseases
/:cl: