Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds storyteller logging and makes roundstart antags actually roll #1427

Merged
merged 17 commits into from
Mar 31, 2024
Prev Previous commit
Next Next commit
oh sick
wraith-54321 committed Mar 18, 2024
commit b8b5039370ce2a923d9dde631a0c727bd1989283
2 changes: 1 addition & 1 deletion code/controllers/subsystem/job.dm
Original file line number Diff line number Diff line change
@@ -238,7 +238,7 @@ SUBSYSTEM_DEF(job)
// Initial screening check. Does the player even have the job enabled, if they do - Is it at the correct priority level?
var/player_job_level = player.client?.prefs.job_preferences[job.title]
if(isnull(player_job_level))
JobDebug("FOC player job not enabled, Player: [player]")
//JobDebug("FOC player job not enabled, Player: [player]")
continue
else if(player_job_level != level)
JobDebug("FOC player job enabled at wrong level, Player: [player], TheirLevel: [job_priority_level_to_string(player_job_level)], ReqLevel: [job_priority_level_to_string(level)]")

Unchanged files with check annotations Beta

var/message = "[subsystem] ([subsystem.type]) is a subsystem meant to initialize but doesn't get set as initialized."
if (subsystem.flags & SS_OK_TO_FAIL_INIT)
TEST_NOTICE(src, "[message]\nThis subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.")

Check notice on line 12 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Integration Tests (deltastation) / run_integration_tests

Delta Station: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but doesn't get set as initialized. This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.

Check notice on line 12 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Integration Tests (icebox) / run_integration_tests

Ice Box Station: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but doesn't get set as initialized. This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.

Check notice on line 12 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Integration Tests (kilostation) / run_integration_tests

Kilo Station: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but doesn't get set as initialized. This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.

Check notice on line 12 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Integration Tests (metastation) / run_integration_tests

MetaStation: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but doesn't get set as initialized. This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.

Check notice on line 12 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Integration Tests (multiz_debug) / run_integration_tests

MultiZ Debug: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but doesn't get set as initialized. This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.

Check notice on line 12 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Integration Tests (northstar) / run_integration_tests

NorthStar: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but doesn't get set as initialized. This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.

Check notice on line 12 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Integration Tests (runtimestation) / run_integration_tests

Runtime Station: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but doesn't get set as initialized. This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.

Check notice on line 12 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Integration Tests (tramstation) / run_integration_tests

Tramstation: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but doesn't get set as initialized. This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.

Check notice on line 12 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Alternate Tests (515, 1627, runtimestation) / run_integration_tests

Runtime Station: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but doesn't get set as initialized. This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.
else
TEST_FAIL(message)