-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing issues with CLI, adding to README, adding to CLI #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sauter-roland
commented
Mar 7, 2024
•
edited
Loading
edited
- Fixed issue with CLI parsing files if comma / tab delimiter didn't fit the file ending. Delimiters are now autodetected.
- Added a detailed description of CLI use to the README, with description of the options.
- Added some options to CLI where easilty possible.
- Added more help text into CLI
- Added tests:
- Automatic download of example files from paper, and Recon3D models for test
- Integration tests using Recon3D and the example files
sauter-roland
force-pushed
the
bug/fix-cli
branch
from
March 8, 2024 08:12
cd7a09f
to
99a0ee4
Compare
sauter-roland
force-pushed
the
bug/fix-cli
branch
from
March 16, 2024 12:13
3f53f5a
to
d4239dd
Compare
sauter-roland
added a commit
that referenced
this pull request
Sep 15, 2024
* Fixing issues with CLI, adding to README, adding to CLI (#37) * csv separator autodetection * more integration tests via cli * Adding proper help text to arguments * adding Recon3D models and sequence data via Git LFS * additional information on readme * json model support for the CLI * add option to only run fast tests * flipping CLI argument order * simplification, fixing tests * adding .mat file support to CLI * fix package version pinning (#41) * fix pinning of package versions that wasn't working * upgrade pylint as the old version crashed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.