Release v2.1.0 #2766
Merged
Release v2.1.0 #2766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs: Add release dates to all change-log files * docs: Add dates for the most recent releases [skip ci]
* Update fetch() browser support in docs As https://caniuse.com/#feat=fetch shows it's supported since Safari 10.1. * Update docs/request.md Co-Authored-By: Isiah Meadows <[email protected]> [skip ci]
* Fix assertion descriptions Move return statement to the end of define() * ospec: Fix assertion definitions * Fix typo in assertion * Add test for descriptions being returned on fail * Reference result instead of self in returned description method * Fix style errors
Skipping CI because it works locally and shouldn't have any impact on tests.
Also, I normalized them to all be sentences for consistency, and I moved the reentrancy check from `m.mount` to `m.render` to be a little more helpful. The router change during mounting is inconsequential and only to avoid the new modified error, and the change to the update loop is to send the original error if an error occurred while initializing the default route. (This is all around more useful anyways.) And while I was at it, I fixed an obscure bug with sync redraws.
Also, restructure a few things for better code reuse.
* Minify stream, add stream stuff to releases again * Kill off a lot of tech debt, drop internal utilities from npm 1. Kill `module/`, internalize `bundler/`, privatize `test-utils/` We've been telling people to move elsewhere from these for a while, and it's about time we just pull the plug here and finally remove them. - We officially removed the bundler from the public API in v2.0, and that was the only one of these that was ever publicly documented. Usage should be low enough by now it shouldn't break anyone- I'm not seeing bundler bugs being reported anymore, either. - The `module/` utility was so narrow and caveat-filled that I'm not sure anyone really used it (even us core Mithril devs never really used it), and we only had it documented in the repo folder it lived in. I think only one bug was ever filed, and it's because it somehow ended up completely non-functional without any of us realizing it. - The test utilities were meant to be internal from day 1, but people started using it despite us core developers constantly telling people to look elsewhere and even the docs recommending specific alternatives without mention of our internal mocks. (Now if people would RTFM, that'd be nice...) 2. Add dedicated HTML test files to verify ospec and the promise polyfill, and ensure the promise tests are in pure ES5. These are made specially for those and should be much easier to just run now. 3. Fix the benchmark script to use the real DOM in browsers and to not require as many dependencies to create. Also, tweak them to be much more effective and precise on what's being tested. Previously, it was rendering to the HTML file itself, while now it's rendering to the `body`. This means in browsers, it's triggering layout and everything, benchmarking how well Mithril optimizes for style and layout recalcs, too. It also puts some pressure on the hyperscript parser attribute application, so that can be noticed as well. * Update dependencies
* Recast key docs to be much clearer and more accurate [skip ci] Also, fix a couple broken hash links I noticed while making this. * Ensure `diff` blocks are highlighted correctly
* Initial addition of flems - fixes #526 * Fix leftover ```js code blocks * Add DOCTYPE * Fix edge & IE11 * Don't show console * Change orientation on mobile * Use mithril@next for playground link * Improve loading and structure * Fix header alignment in IE * Don't rotate logo * Fix conflicts * Allow `js` tags * Fix code block query * Fix Routing section and flems * Fix firefox * Improve flems styling * Improve copy * Fix data -> body in m.request sample * Add flems in docs usage description
### Pimp the docs linter (and assorted changes) #### `scripts/lint-docs.js` - Add an optional cache for faster runs - Add a final report - Don't return anything from `exec()` - Cover more files #### `scripts/_command.js` - Look for a "--cache" option #### `package.json` scripts - Added `watch:lint-docs` - Added `cleanup:lint` to remove the eslint and lint-docs cache files - Changed `lint:docs` to use the `--cache` option - Added `test:js` so that we can run the test suite without the linter - Changed `test` to defer to `test:js` #### Actual lint fixes: - Bad link in a migration guide - The unicode dashes in the "https://en.wikipedia.org/wiki/Subject–verb–object" are not escaped by marked ### Some more lint-docs pimping #### `scripts/lint-docs.js` - some code reorg and cleanup (take a hint from the local coding conventions) - fix misc bugs - pass a User-Agent header to the requests - even nicer reporting #### `package.json` - bump the @babel/parser dep to the latest #### Docs - tweaks based on lints missed due to previous bugs ### Docs: use the github page for velocity.js, the home page has too many errors. Co-Authored-By: Isiah Meadows <[email protected]>
* remove docs archive (fix #2552) * Update docs/change-log.md Co-Authored-By: Isiah Meadows <[email protected]> Co-authored-by: Isiah Meadows <[email protected]>
Co-authored-by: Isiah Meadows <[email protected]>
* change link to go to ospec instead of mocha Updated link regarding [issue 2575](#2575) * Update docs/testing.md Co-authored-by: Isiah Meadows <[email protected]>
There is a small typo in mithril.js, render/render.js. Should read `subsequence` rather than `subsequece`.
Co-authored-by: Stephan Behnke <[email protected]>
Co-authored-by: Isiah Meadows <[email protected]>
Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.3. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.20. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
JAForbes
added
Area: Core
|
⚠⚠⚠ Hey @JAForbes, did you mean to open this against |
Triggering multiple concurrent runs unnecessarily
|
The above merged PRs should have been labeled according to the following logic, unless I managed to miss something in my runthroughs... |
* Simpler m.route.Link documentation. Fixes #2767 * Remove redundant HTML encoding from markdown docs * Warn about m.route.Link immunity to event handler API. * Integrate @JAForbes review corrections * Example code typo in docs/route.md Co-authored-by: Matias Kinnunen <[email protected]> Co-authored-by: Matias Kinnunen <[email protected]>
|
do we really have one version jump for every merged pr, @JAForbes ? |
|
Something along these lines would be closer to what we want I think: const level = ['none', 'prerelease', 'patch', 'minor', 'major' ]
.reduce((current, candidate) => severityIdx[candidate]?.length ? candidate : current)
let nextVersion
if (level === 'none') {
// prerelease business
} else
nextVersion = semver.inc(semver.clean(version), level)
} |
|
Yeah that is how it works, but I could add some alternate versioning logic. Do you want it to do the minimum necessary semver bump? E.g. last release was 2.0.4, there was at least 1 minor, so this release is 2.1.0? |
This is a concise version of what I tried to express with code, yes... Let's see what the others think |
|
Don't really care about the outcome that much, but my understanding is that following semver roughly and assuming that we merge by calendar time according to above, the actual outcome "should have been" 2.7.0, since the patch number is reset on minor bumps... |
|
It worked @JAForbes 🎉 |
dead-claudia
approved these changes
May 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release v2.1.0
change-logtochangelog, fix a few assorted bugs #2578params:tom.route.Link, fix docs #2537m.Fragment = "["utility for JSX users. #2744m.censor, adjustm.route.Linkto use it #2538Changelog
Minor Changes
m.censor: work around a bunder bug (@kfule)
The internal bundler sometimes mangles the words in RegExp literals incorrectly. Please see below.
Warn about reusing mutated attrs object - fixes #2719 (@StephanHoyer)
Send URLSearchParams as request body without extra configuration (@Coteh)
This PR fixes an oddity I noticed in the way
m.requesthandlesURLSearchParamsobject. It now handles it in the same sort of way XHR and Fetch do it.Add
params:tom.route.Link, fix docs (@dead-claudia)Add
params:tom.route.Link. Minor fix to docs to reflect reality withm.route.Link'sdisabled:attribute.Allow Mithril to be loaded in non-browser environments without modification (@dead-claudia)
Recast the global reads to all be guarded with
typeof, so that if they aren't defined, they're justnull.Add a
m.Fragment = "["utility for JSX users. (@dead-claudia)The title says it all, and the diff's obvious. Resolves #2640 and probably others.
Patch Changes
Enable --minimize-semver-change for pr-release (@JAForbes)
Minimizes semver changes on release to the minimum required version bump to satisfy major/minor/patch semver ranges. Minimizes the semver change so that.
Clean up m.route.Link (@barneycarroll)
An attempt at better demonstrating
m.route.Linkwith less text. Fixes #2767.Runtime-deprecate ospec, change
change-logtochangelog, fix a few assorted bugs (@dead-claudia)This PR is in two parts: 1. Revise the build system and some of the local dev setup. Fully split ospec from the repo, and add it as a dependency.
Add meta description to docs (@StephanHoyer)
rework of #2149. added a meta description parser and meta descriptions to all docs pages. because google. built the docs, inspected the output manually.
Fixed badges, consistent naming of Mithril.js (@tbreuss)
use consistent naming of Mithril.js. fix badges in README. Fixes issue #2749.
Catch malformed URI Components (@jdiderik)
Fix for error thrown when a value contains non-valid / malformed URI Component. Example: test=%c5%a1%e8ZM%80%82H. will throw "URI malformed".
Correctly handle invalid escapes in routes based on 0a5ead31c9fbd7b153c521c7f9d3df7bf826ce6c (@StephanHoyer)
fixes #2061. @dead-claudia I just redid your change but slightly different in order to handle a mix of wrong and right encodings properly.
Standardise vnode text representation (@barneycarroll)
This addresses the crucial feature of #2669: text is always represented as virtual text nodes, never as a
vnode.text.Issue 2624 no content 204 parse (@Evoke-PHP)
Added guard so that JSON.parse does not fail on IE11 with no content empty string being parsed. Fixes #2624.
[m.request] work around a bundler bug, fix #2647 (@pygy)
The bundler mangles identifier-like strings within RegExps, this works around the problem by not using such RegExps.
Reject request on XHR timeout (@kevinfiol)
Derived from PR #2581. Allows requests to properly reject on event of a timeout.
Remove extra isLifecycleMethod call from removeAttr (@ZeikJT)
Removing an extra isLifecycleMethod in the removeAttr method, it isn't needed since it's already checked on the previous line.
Fix #2601 (@dead-claudia)
Fix issue where ending a stream in the middle of a stream callback would result in erroneous parent stream state for the rest of that emit. Fixes #2601.
Add streams to releases again, include minified bundle, drop internal stuff from npm (@dead-claudia)
Add
stream/stream.jsto releases again. Addstream/stream.min.jsnow that the process is remotely sane now.Make errors and their messages more accurate and helpful (@dead-claudia)
I updated error messages to be much more helpful.
Fix assertion descriptions (@soulofmischief)
I moved the return statement to the end of define() so that it returns even if the comparison fails.
Fix branch target (@dead-claudia)
https://github.com/MithrilJS/mithril.js/runs/6199543939?check_suite_focus=true.
Automate mithril's release workflow (@JAForbes)
Automated releases, pre-releases, (code) rollbacks and recovery, npm publishing, change log management just by using normal github flow.
rework jsx docs (@StephanHoyer)
Add Simple Application Flems Supporting v2.0.4 and up (@tbreuss)
Added Flems for Simple Application supporting v2.0.4 of Mithril.js. Fixes Issue #2710.
Make example work with webpack v5.69.1 (@StephanHoyer)
fixes #2634.
2604: correct and move text about statements in view method (@kevinfiol)
Addresses #2604.
Fix lint errors (@StephanHoyer)
WIP: Update modularisation details in Installation docs (@orbitbot)
added link to flems.io as an easier way to just try out the framework. -. Documentation has grown a bit stale.
Added power support for the travis.yml file with ppc64le (@sreekanth370)
Added power support for the travis.yml file with ppc64le. This is part of the Ubuntu distribution for ppc64le.
Updated babel/webpack docs to work with latest versions (@pereriksson)
As a developer I tried setting up Mithril with Babel and Webpack but failed because of a variety of errors.
[docs] route redirection using the history API (@pygy)
This is an attempt at fixing #1759, but there may be more to be added. Feedback welcome. ping @dontwork.
Bump path-parse from 1.0.6 to 1.0.7 (@dependabot[bot])
Bumps path-parse from 1.0.6 to 1.0.7. Commits. See full diff in compare view.
Bump glob-parent from 5.1.0 to 5.1.2 (@dependabot[bot])
Bumps glob-parent from 5.1.0 to 5.1.2. Release notes. Sourced from glob-parent's releases. v5.1.2. Bug Fixes.
Bump ajv from 6.10.2 to 6.12.6 (@dependabot[bot])
Bumps ajv from 6.10.2 to 6.12.6. Release notes. Sourced from ajv's releases. v6.12.6. Fix performance issue of "url" format.
Update standalone usage (@ghost)
Avoid double encoding of function signatures - fixes #2720 (@StephanHoyer)
Show previous versions (@mike-ward)
Add Dropdown that shows links to archived versions of the documentation.
docs: improve m.request return value description (@GAumala)
In the m.request return value description, add a line informing that error status codes cause the promise to reject.
A note on JSX events (@pereriksson)
Naming JSX events according to their documentation produces unexpected results with incorrectly named events when using JSX with Mithril.
Document route resolution cancellation, fixes #1759 (@barneycarroll)
Also fixes a broken internal link.
Bump marked from 0.7.0 to 4.0.10 (@dependabot[bot])
Bumps marked from 0.7.0 to 4.0.10. Release notes. Sourced from marked's releases. v4.0.10. 4.0.10 (2022-01-13). Bug Fixes.
Flems in docs (#2348) [skip ci] (@porsager)
Added flems instead of the current codepen samples.
Remove old TOC link (@ArthurClemens)
Content was moved some time ago and linked section no longer exists.
Cavemansspa patch 1 (@cavemansspa)
Documentation update.
Bump hosted-git-info from 2.8.4 to 2.8.9 (@dependabot[bot])
Bumps hosted-git-info from 2.8.4 to 2.8.9. Changelog. Sourced from hosted-git-info's changelog. 2.8.9 (2021-04-07).
Bump lodash from 4.17.20 to 4.17.21 (@dependabot[bot])
Bumps lodash from 4.17.20 to 4.17.21. Commits. f299b52 Bump to v4.17.21.
Bump handlebars from 4.7.6 to 4.7.7 (@dependabot[bot])
Bumps handlebars from 4.7.6 to 4.7.7. Changelog. Sourced from handlebars's changelog. v4.7.7 - February 15th, 2021.
Remove unreachable keyed node logic, fixes #2597 (@barneycarroll)
Delete test-utils/README.md (@dead-claudia)
We don't expose this publicly anymore, so there's literally no justification for this file's existence.
simple-application.md: consistent use of type=submit (@danbst)
When following tutorial and typing everything in, I was confused that Save button didn't work.
Fix inconsistent capitalizations of "JavaScript" (@mtsknn)
"Javascript"/"javascript" → "JavaScript". Fixes #2398, or at least I can't find any more incorrect capitalizations.
fix some typos (@osban)
Found some typos. Mainly unescaped
|in tables, but also a few other irregularities. Not all problems are visible in the website docs.Replace mocha by ospec in testing page (@gamtiq)
Fixed a typo in testing doc page. Currently there is reference to
mochain the page whereasopsecis used.Bump acorn from 7.1.0 to 7.4.0 (@dependabot[bot])
Bumps acorn from 7.1.0 to 7.4.0. Commits. 54efb62 Mark version 7.4.0.
Bump handlebars from 4.4.2 to 4.7.6 (@dependabot[bot])
Bumps handlebars from 4.4.2 to 4.7.6. Changelog. Sourced from handlebars's changelog. v4.7.6 - April 3rd, 2020.
Bump lodash from 4.17.15 to 4.17.20 (@dependabot[bot])
Bumps lodash from 4.17.15 to 4.17.20. Commits. ded9bc6 Bump to v4.17.20. 63150ef Documentation fixes.
Bump minimist from 1.2.0 to 1.2.3 (@dependabot[bot])
Bumps minimist from 1.2.0 to 1.2.3. Commits. 6457d74 1.2.3. 38a4d1c even more aggressive checks for protocol pollution.
Update installation.md (@purefan)
Offer to install mithril as a webpack plugin. Just makes my life easier by not having to include mithril in every one of my js files.
replace slave label with replica (@stephanos)
One of the example is using the antiquated word "slave" for a database replica. I updated the language and tested the change.
ES6 and m.trust docs patch (@kczx3)
While reading through some of the documentation I saw some issues with both the ES6 and
m.trustpages.docs: Fix simple typo, subsequece -> subsequence (@timgates42)
There is a small typo in mithril.js, render/render.js. Should read
subsequencerather thansubsequece.change link to go to ospec instead of mocha (@akessner)
Change the link to point to ospec docs in github. ospec link went to mochajs. issue 2575. N/A. N/A. N/A.
updated to the Vimeo showcase (@CreaturesInUnitards)
The scrimba version of Mithril 0-60 was built on their beta platform, and doesn't really even work anymore.
adding more community examples (@boazblake)
Exclude archive of previous docs (@cztomsik)
update .npmignore so that archives are not included in the resulting package. space/bandwidth savings. fix #2552.
Pimp the docs linter (and assorted changes) (@pygy)
Add an optional cache for faster runs. Add a final report. Don't return anything from
exec(). Cover more files. Look for a "--cache" option.Recast key docs to be much clearer and more accurate (@dead-claudia)
Recast key docs to be much clearer and more accurate, including a few Flems examples to help intuitively explain things.
Add
m.censor, adjustm.route.Linkto use it (@dead-claudia)Add
m.censor. Adjustm.route.Linkto use it. Restructure a few things for better code reuse. Fixes #2472.Update fetch() browser support in docs (@qgustavor)
As Can I use shows
fetch()supported since Safari 10.1 and iOS Safari 10.3.docs: Add release dates to all change-log files (@maranomynet)
I'd like to introduce release dates to the change log files. Release dates are human-friendly and add a bit of historical perspective to change-log files.