Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra isLifecycleMethod call from removeAttr #2594

Merged
merged 2 commits into from
May 17, 2020
Merged

Remove extra isLifecycleMethod call from removeAttr #2594

merged 2 commits into from
May 17, 2020

Conversation

ZeikJT
Copy link
Contributor

@ZeikJT ZeikJT commented May 8, 2020

Description

Removing an extra isLifecycleMethod in the removeAttr method, it isn't needed since it's already checked on the previous line. It is similarly only checked once in setAttr.

How Has This Been Tested?

I ran npm test as instructed. I also ran npm run lint as a sanity check.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@ZeikJT ZeikJT requested a review from dead-claudia as a code owner May 8, 2020 03:22
Copy link
Member

@dead-claudia dead-claudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other thing: could you update the changelog?

@ZeikJT
Copy link
Contributor Author

ZeikJT commented May 13, 2020

Sorry for the late response. To be clear, do you want me to add a 2.0.5 section in the change-log for this change?

@dead-claudia
Copy link
Member

@ZeikJT No, in the commented-out section of it for the upcoming changes.

@ZeikJT
Copy link
Contributor Author

ZeikJT commented May 15, 2020

Ah! Sorry, I hadn't looked at the file content and only saw the preview which didn't show the commented out section :)

Updated the change-log.

@dead-claudia dead-claudia merged commit cf7a841 into MithrilJS:next May 17, 2020
@JAForbes JAForbes mentioned this pull request Apr 28, 2022
@orbitbot orbitbot added the patch label May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants