Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix/catch-transition-frontier-errors Update transition_frontier.ml… #6943

Merged
merged 69 commits into from
Dec 4, 2020

Conversation

lk86
Copy link
Contributor

@lk86 lk86 commented Dec 4, 2020

… to match feature/catch-transition-frontier-errors

Thank you for contributing to Coda! Please see CONTRIBUTING.md if you haven't
yet. In that doc, there are more details around how to start our CI.

Explain your changes here.

Explain how you tested your changes here.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

Closes #0000
Closes #0000

nholland94 and others added 30 commits November 10, 2020 16:57
Add Rosetta model enums for blockeventtype, exemptiontype, and operator
In Rosetta 1.4.7 "options" is no longer required. Our code requires some
of its fields to be set though so we'll error out when it's not
provided.
- Update `rosetta_models` to version 1.4.7 using code generator and undo
  any undesired changes (like removal of annotations)
- Remove `coins` field from `AccountBalanceResponse`
- Make `status` field on `Operation` optional (essentially wrap in
  `Some` throughout and wrap certain `String.equal` calls with
  `Option.equal`)
- Make `ConstructionMetadataRequest` `options` field optional (but just
  error out if it's not set)
- Add `description` to `Errors` (initially set to the same thing as
  `message`, but Rosetta allows `description` to be modified whenever
  we choose)
- Set values for new `historical_balance_lookup`, `call_methods`,
  `balance_exemptions`, and `mempool_coins` fields in network options
- Set temporary value for new `timestamp_start_index` field in network
  options along with TODO+issue describing how to implement it correctly
  in the future
@lk86 lk86 requested a review from mrmr1993 December 4, 2020 18:14
@lk86 lk86 requested a review from a team as a code owner December 4, 2020 18:14
@lk86 lk86 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Dec 4, 2020
lk86 and others added 2 commits December 4, 2020 13:30
Merging the hotfix branch into develop now that master changes are released + tested to keep the branches in sync
@mrmr1993
Copy link
Member

mrmr1993 commented Dec 4, 2020

Pulled in #6881.

@lk86 lk86 requested a review from a team as a code owner December 4, 2020 19:10
@lk86 lk86 merged commit f5aa1fb into master Dec 4, 2020
@lk86 lk86 deleted the hotfix/catch-transition-frontier-errors branch December 4, 2020 19:48
@lk86 lk86 restored the hotfix/catch-transition-frontier-errors branch December 4, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants