-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotfix/catch-transition-frontier-errors Update transition_frontier.ml… #6943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Rosetta model enums for blockeventtype, exemptiontype, and operator
In Rosetta 1.4.7 "options" is no longer required. Our code requires some of its fields to be set though so we'll error out when it's not provided.
- Update `rosetta_models` to version 1.4.7 using code generator and undo any undesired changes (like removal of annotations) - Remove `coins` field from `AccountBalanceResponse` - Make `status` field on `Operation` optional (essentially wrap in `Some` throughout and wrap certain `String.equal` calls with `Option.equal`) - Make `ConstructionMetadataRequest` `options` field optional (but just error out if it's not set) - Add `description` to `Errors` (initially set to the same thing as `message`, but Rosetta allows `description` to be modified whenever we choose) - Set values for new `historical_balance_lookup`, `call_methods`, `balance_exemptions`, and `mempool_coins` fields in network options - Set temporary value for new `timestamp_start_index` field in network options along with TODO+issue describing how to implement it correctly in the future
add node selector named templates to express preemptible + custom node affinity
…rontier-errors Retry transition frontier init if load_from_persistence_and_start fails
Prune validation callbacks from queues if they are expired
clean-up-lock-k8s
… to match feature/catch-transition-frontier-errors
mrmr1993
approved these changes
Dec 4, 2020
…ure/clear-external-transition-db-if-error
mrmr1993
approved these changes
Dec 4, 2020
Merging the hotfix branch into develop now that master changes are released + tested to keep the branches in sync
…/catch-transition-frontier-errors
Pulled in #6881. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to match feature/catch-transition-frontier-errors
Thank you for contributing to Coda! Please see
CONTRIBUTING.md
if you haven'tyet. In that doc, there are more details around how to start our CI.
Explain your changes here.
Explain how you tested your changes here.
Checklist:
Closes #0000
Closes #0000