Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record location that mask parents are nulled at for dangling parent ref #6881

Merged
merged 7 commits into from
Dec 3, 2020
Merged

Record location that mask parents are nulled at for dangling parent ref #6881

merged 7 commits into from
Dec 3, 2020

Conversation

mrmr1993
Copy link
Member

This changes the parent field for Masking_merkle_tree to record the location that unset the parent. This gives us more useful context for Dangling_parent_reference exceptions if/when they occur.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 requested a review from a team as a code owner November 30, 2020 20:57
deepthiskumar
deepthiskumar approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@deepthiskumar deepthiskumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@deepthiskumar deepthiskumar added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop labels Nov 30, 2020
@mergify mergify bot merged commit f3d941e into develop Dec 3, 2020
@mergify mergify bot deleted the feature/dangling-parent-reference-location branch December 3, 2020 03:53
@mrmr1993 mrmr1993 mentioned this pull request Dec 4, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthiskumar deepthiskumar deepthiskumar approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @deepthiskumar