Fix dangling_mask during catchup #6752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost-not-in-the-shell
added
the
ci-build-me
mrmr1993
requested changes
Nov 18, 2020
| let ip_address_set = | ||
| let sender_from_tree_node node = | ||
| Envelope.Incoming.sender (Cached.peek node) | ||
| try |
There was a problem hiding this comment.
This try may not work if the async scheduler decides to run the code in a different thread. You should change this to use Deferred.Or_error.try_with or similar.
There was a problem hiding this comment.
Ok. I would do that.
mrmr1993
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6732
Close #6731