Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop transitions in breadcrumb_builder if it's parent has been garbage collected #6732

Closed
ghost-not-in-the-shell opened this issue Nov 17, 2020 · 0 comments · Fixed by #6752
Assignees

Comments

@ghost-not-in-the-shell
Copy link
Contributor

ghost-not-in-the-shell commented Nov 17, 2020

We recently have seen that multiple user nodes crashed with "dangling mask error" (#6731) which is caused by the following scenario:

  1. A node boots up and finds the network is relatively close to its best tip so it tries to do catchup.
  2. Before it finishes catchup, the network moves forward and causes the node to do bootstrap.
  3. The catchup process is still working on the old frontier which has been garbage collected.

To be specific, here:

Transition_frontier.Breadcrumb.build ~logger

The call to Breadcrumb.build assumes that parent is still valid.

One option is to move the check closer to Breadcrumb.build function, another option would be change the assertion to an exception and catch the exception in Breadcrumb_builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant