Integrate and enable new rust bindings #6579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntegrate-ocaml-heap-rust-bindings
mrmr1993
added
the
ci-build-me
imeckler
reviewed
Nov 3, 2020
| module Bignum_bigint = Snarky_backendless.Backend_extended.Bignum_bigint | ||
|
|
||
| (* |
imeckler
reviewed
Nov 3, 2020
|
|
||
| (* |
imeckler
reviewed
Nov 3, 2020
| val sqrt : t -> t | ||
|
|
||
| val det_sqrt : t -> t | ||
| (*val det_sqrt : t -> t |
imeckler
approved these changes
Nov 3, 2020
Base automatically changed from
feature/update-rust-ocaml-heap-bindings
to
develop
November 3, 2020 17:55
imeckler
added
ready-to-merge-into-develop
and removed
ready-to-merge-into-develop
labels
|
Deploy preview for mina-staging ready! Built with commit 11b6c87 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the latest version of the bindings with the pickles library and the system on-the-whole.
As it stands, there could be more type sharing and things could have been better restructured, but compiles and appears to work as-is.
This should be mostly ready for review, but I am still testing and may have to make minor tweaks if anything is working incorrectly.
Checklist: