Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift snarky_bn382 from the zexe repo #6464

Closed
wants to merge 103 commits into from
Closed

Uplift snarky_bn382 from the zexe repo #6464

wants to merge 103 commits into from

Conversation

mrmr1993
Copy link
Member

This PR moves the snarky_bn382 library from the zexe repo into src/lib/snarky-bn382. This breaks the dependency of the marlin and zexe repos on eachother.

This uses the git subtree commands, so commits describing the history of the library from the zexe repo are conserved.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

mrmr1993 and others added 30 commits December 10, 2019 18:36
@mrmr1993
Initial linking and build for stubs
30498f4
@mrmr1993
Add bindings for the remainder of the field interface
6c2103c
@mrmr1993
Add field interface declarations to the .h file
eb54b45
@mrmr1993
Bindings for field interface
a1ffe34
@mrmr1993
Test for all field bindings
9c046b5
@mrmr1993
Delimiting comments for field vectors
47038dd
@mrmr1993
WIP BigInteger implementation
728fce8
@mrmr1993
Fix conversion from bigint to biginteger
9f080d4
@mrmr1993
Fixup tests
6a65ae3
@imeckler
fix some things, add bindings for things in rust
393686d
@imeckler
corresponding bindings in ocaml
98b381a
@imeckler
update the test
0a3fb40
@imeckler
update the bindings in rust
3074e60
@imeckler
reference to marlin in dune dependencies
725452e
@imeckler
fix compilation
0fa9f51
@imeckler
more bindings
fc21387
@imeckler
bindings for new functionality
6dc4c05
@imeckler
ocaml side of the bindings
acf8b3d
@imeckler
add commitment to cargo
ea4ee49
@imeckler
progress
80469c6
@imeckler
additional bindings
5ef2c13
@imeckler
change cargo backg
5c9e931
@imeckler
switch to use multiple prev challenge polynomials, remove debugging code
ac9542d
@imeckler
change cargo paths
eecba04
@imeckler
some updates
9617b36
@imeckler
add groupmap to dune
f3c599d
@imeckler
various additional bindings for verifier
4728584
@ltvvlz
final modifications for split polycommitment support in Snarky backend
058d96c
@imeckler
changes required for the endomorphism trick
e39d6bb
@imeckler
Merge remote-tracking branch 'origin/working-branch-with-modified-car…
4f952b2 
…go' into split-poly-comms-and-endo-trick
mrmr1993 and others added 22 commits September 17, 2020 16:51
@mrmr1993 @imeckler @ltvvlz
Drag master into line with split-working-branch (#27)
faed8d7 
* change cargo paths

* some updates

* add groupmap to dune

* various additional bindings for verifier

* final modifications for split polycommitment support in Snarky backend

* changes required for the endomorphism trick

* fix verifier

* fix verifier

* local cargo

* fix compilation

* working code

* fix to work with the new zexe

* move things around

* cargo fix

* cleanup

* rename, add tweedle bindings

Co-authored-by: Izaak Meckler <[email protected]>
Co-authored-by: Ltvvlz <[email protected]>
@mrmr1993
Merge branch 'master' into feature/fixup-for-marlin-bump
823ef76
@mrmr1993
Merge branch 'master' into feature/fixup-for-marlin-bump
aeefc49
@mrmr1993
Merge branch 'master' into feature/turbo-plonk-bindings
2d4b1d6
@mrmr1993
Merge branch 'master' into feature/plonk-constraint-system
954b237
@mrmr1993
Merge branch 'master' into feature/stop-leaks-plonk
56556e9
@mrmr1993
Merge branch 'master' into fix/evals-type
d603837
@mrmr1993
Merge branch 'master' into fix/evals-type
81197b5
@mrmr1993
Use gate vector instead of constraint systems for generating indexes
501805b
@ltvvlz @mrmr1993
when creating index, transform gate wires into witness form
96e067d
@mrmr1993
Reformat using cargo fmt
4494fee
@mrmr1993
Fixup batch_accumulator_check
ddfbd58
@mrmr1993
Reformat
1ba129f
@mrmr1993
Merge branch 'fix/master-fixup' into feature/merge-with-plonk-bindings2
8ce66ba
@mrmr1993
Fixup header file warnings
fc3659e
@mrmr1993
Merge branch 'master' into feature/batch-verify-across-keys
e170624
@mrmr1993
Merge branch 'master' into detsqrt
2442f7b
@mrmr1993
Merge pull request #33 from o1-labs/feature/batch-verify-across-keys
d9194f1 
Batch verify across keys
@mrmr1993
Remove snarky-bn382 from zexe
8ea525c
@mrmr1993
Add 'src/lib/snarky-bn382/' from commit 'd9194f13d7cc7aba0fa65e3945fb…
1169905 
…92ed160ca653'

git-subtree-dir: src/lib/snarky-bn382
git-subtree-mainline: 8ea525c
git-subtree-split: d9194f1
@mrmr1993
Move snarky-bn382.opam file into library directory
a2a1d37
@mrmr1993
Update relative paths in moved snarky-bn382
76bcdc1
@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Oct 21, 2020
@mrmr1993 mrmr1993 mentioned this pull request Oct 21, 2020
Closed
@mrmr1993
Copy link
Member Author

Superseded by the new bindings in #6545, #6579.

@mrmr1993 mrmr1993 closed this Nov 10, 2020
@mrmr1993 mrmr1993 deleted the feature/uplift-snarky-bn382 branch November 10, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrmr1993 @imeckler @ltvvlz