Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle expired transactions in transaction pool #6198

Merged
merged 14 commits into from
Oct 2, 2020
Merged

handle expired transactions in transaction pool #6198

merged 14 commits into from
Oct 2, 2020

Conversation

deepthiskumar
Copy link
Member

  • Remove any expired transactions from the pool on every best tip change
  • check expiry when adding new transactions to the pool

Note: Snapp commands are valid forever

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

Closes #6074

@deepthiskumar deepthiskumar changed the title handle expired transactions in transaction pool [Do not review] handle expired transactions in transaction pool Sep 30, 2020
@deepthiskumar
Copy link
Member Author

Based on the review comments from #6148

@deepthiskumar deepthiskumar changed the title [Do not review] handle expired transactions in transaction pool handle expired transactions in transaction pool Sep 30, 2020
mrmr1993
mrmr1993 approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Sep 30, 2020
Base automatically changed from fix/refactor-pool-error to develop September 30, 2020 17:06
@netlify
Copy link

netlify bot commented Sep 30, 2020 •
edited
Loading

Deploy preview for mina-staging ready!

Built with commit 44b917f

https://deploy-preview-6198--mina-staging.netlify.app

@mergify mergify bot merged commit 552b1e7 into develop Oct 2, 2020
@mergify mergify bot deleted the fix/txn_expiry2 branch October 2, 2020 08:40
@mrmr1993 mrmr1993 mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transactions in the pool are not purged when their valid_until period has elapsed
2 participants
@deepthiskumar @mrmr1993