Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transactions in the pool are not purged when their valid_until period has elapsed #6074

Closed
mrmr1993 opened this issue Sep 21, 2020 · 0 comments · Fixed by #6198
Closed

Transactions in the pool are not purged when their valid_until period has elapsed #6074

mrmr1993 opened this issue Sep 21, 2020 · 0 comments · Fixed by #6198
Assignees
@deepthiskumar
Milestone
Adversarial TestNet

Comments

@mrmr1993
Copy link
Member

Currently, there is no check in the pool that the valid_until field of transactions is less than the current global slot. This violates the invariant that all transactions are valid against the current head, and a sufficiently high-fee expired transaction will cause block producers to examine it first, reject it, and produce a block with no transactions.

The corresponding log message is at level fatal, but we never do any special handling of the failure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepthiskumar deepthiskumar

Labels
None yet
Projects
None yet
Milestone
Adversarial TestNet
3 participants
@mrmr1993 @deepthiskumar @aneesharaines