Fixes for release #6036

mrmr1993 · 2020-09-18T17:51:55Z

Checklist:

Document code purpose, how to use it
- Mention expected invariants, implicit constraints
Tests were added for the new behavior
- Document test purpose, significance of failures
- Test names should reflect their purpose
All tests pass (CI will check this if you didn't)
Serialized types are in stable-versioned modules
Does this close issues? List them:

The failing transaction that triggered the bug is sexp-encoded below: (Transition((source 27134468903224750529798419383466651480643382403122098213313776918881001950363)(target 21429950356076183907646481246696156098264848370188969195507413076760273877044)(supply_increase 0)(pending_coinbase_stack_state((source((data 23140642383725271192818829662423906112345096325302005775638625498385383088111)(state((init 18725600149482768702122737662018824018365718553036858974032547020773471844694)(curr 27260294281602374269476094649596017740985468431422255816900467305005071439936)))))(target((data 23140642383725271192818829662423906112345096325302005775638625498385383088111)(state((init 18725600149482768702122737662018824018365718553036858974032547020773471844694)(curr 27260294281602374269476094649596017740985468431422255816900467305005071439936)))))))(fee_excess((fee_token_l 1)(fee_excess_l((magnitude 100000000)(sgn Pos)))(fee_token_r 1)(fee_excess_r((magnitude 0)(sgn Pos)))))(next_available_token_before 7)(next_available_token_after 7)(sok_digest()))(User_command((payload((common((fee 100000000)(fee_token 1)(fee_payer_pk B62qkJRrnN1cYGkZWA9b8DzbDdeeq9nz3NazMfFiVvCKVMa2NkkFDxL)(nonce 1)(valid_until 4294967295)(memo"\001\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000")))(body(Create_token_account((token_id 7)(token_owner_pk B62qkJRrnN1cYGkZWA9b8DzbDdeeq9nz3NazMfFiVvCKVMa2NkkFDxL)(receiver_pk B62qkJRrnN1cYGkZWA9b8DzbDdeeq9nz3NazMfFiVvCKVMa2NkkFDxL)(account_disabled false))))))(signer B62qkJRrnN1cYGkZWA9b8DzbDdeeq9nz3NazMfFiVvCKVMa2NkkFDxL)(signature(13374024090322643499355720867512380232924020337001248327857754269075545360996 2560634850914103389459956296506726599993288779980957924184017465299457615629))))((ledger((indexes(((B62qkJRrnN1cYGkZWA9b8DzbDdeeq9nz3NazMfFiVvCKVMa2NkkFDxL 7)1032)((B62qkJRrnN1cYGkZWA9b8DzbDdeeq9nz3NazMfFiVvCKVMa2NkkFDxL 7)1032)((B62qkJRrnN1cYGkZWA9b8DzbDdeeq9nz3NazMfFiVvCKVMa2NkkFDxL 1)648)))(depth 14)(tree(Node 27134468903224750529798419383466651480643382403122098213313776918881001950363(Node 19774992335399779194689588316362921287846756769333861501717273717443321915098(Node 25070876951797295031091819031479473566465485106851877596532610129836382743483(Node 13804786426824376726501337242117829205805253066442580110212619635737005157565(Node 26131265955736015229337047827503961450456720486043225167622847194377263616708(Hash 11425460328068333852052812817492899706643983637067084488261307338635029227692)(Node 8102390577840071785110816758871904756559631234302195038897961499247565631625(Node 24048244688612833966742226504796923502726811438385800322193136530605665326482(Hash 18628537809890434877804138243617583150093885097251155616638203440991995397190)(Node 20160352777691737945914779681488132314868845911139062150914228642093876061735(Node 4240933149594213972060220101345855706564679658806867010691011656651388638427(Node 7030272686084982847668279607997096076161049778202209305488885780886769100815(Node 20716515114021034656010147433417078558797107602215023742626916200167416761864(Hash 8684112556783003614024905165040000309271718668914111753877162048191500017303)(Node 4070531036553952730387004207260794285922834780832124288559083536347666975216(Node 11927555775837262744948251657799891889478189919710191282930497581180451892818(Node 24242985539350332602196897544201117977142230279089379411742913829599277507572(Account((public_key B62qkJRrnN1cYGkZWA9b8DzbDdeeq9nz3NazMfFiVvCKVMa2NkkFDxL)(token_id 1)(token_permissions(Not_owned(account_disabled false)))(balance 508900000000)(nonce 1)(receipt_chain_hash 27237097349500861140035642726193936327384666627897845124792778810790834184763)(delegate B62qkJRrnN1cYGkZWA9b8DzbDdeeq9nz3NazMfFiVvCKVMa2NkkFDxL)(voting_for 0)(timing Untimed)))(Hash 20447918226074206859565805515566271222292392944689558379654945097523442021618))(Hash 23215120321964934169401377502158800808270536266223086496210982701689094348201))(Hash 19528890530405189688389506727149030565847609044425555986204325143089958610573)))(Hash 13639543489233009034227983458902256673882311871065831444659916537654030717433))(Hash 11861170009579794334562735894255074304892677465622466656928533368317343130909))(Hash 1624017973644397284159330909354875558797162588246267188899480759322362600772)))(Hash 7832521639686271821825360571831964100190678656865263425008113674553470079646)))(Node 10152564595843679559853576686513176699384359957846709351133854544460298018943(Node 11763187441827063665095831571023289715613782380349318483485654241353582119409(Node 2469253893383391012382243278397279076233393873361802371756184858825609105831(Node 16676370340859952237163990535119878613231024365145694363112973743687524420355(Node 12384162740233605749214767352716499462773296394336459575915332900408409905464(Node 25002768640728427095029865264615053435779741162388008065275988325212185183408(Node 2724654539540278151889529954493774445643312962667976055183644470791884828240(Hash 2510982881216336006205893394659759584271325422787637275785165147961199438353)(Node 2732137107111707916815359195698907738347477853625906122748708562110667003700(Node 22886800136969721296022797350821377853139996767997531899346726346995748716994(Node 12223544193217301573648994243183600112729569488762897641705793256328371798581(Account((public_key B62qiTKpEPjGTSHZrtM8uXiKgn8So916pLmNJKDhKeyBQL9TDb3nvBG)(token_id 1)(token_permissions(Not_owned(account_disabled false)))(balance 0)(nonce 0)(receipt_chain_hash 15652585235832934921583570765124908656262401037373930895195709801952924295710)(delegate B62qiTKpEPjGTSHZrtM8uXiKgn8So916pLmNJKDhKeyBQL9TDb3nvBG)(voting_for 0)(timing Untimed)))(Hash 4468385704029054812757068841780457499478478837717273050865921275063507147937))(Hash 12223544193217301573648994243183600112729569488762897641705793256328371798581))(Hash 22886800136969721296022797350821377853139996767997531899346726346995748716994)))(Hash 15860354175263840235631517252333745025839932649990485854444394856622623366746))(Hash 3114025260803998144510634520419049565315319056570952018769134793065235170543))(Hash 19037790595742324731008215269424411031039875753226042883761281351432239020735))(Hash 5991895123077538663571569381770353614051750395398743534641041336163769326404))(Hash 20186076215208085838601165213386167974027758767076534863092406101873737175013))(Hash 24033266339169900877351832551071769000684000939585006171903225629998891287808)))(Hash 1900135125302463214394010648604411958151825345055406313393935004355233472345))(Hash 15021775575191935322932253138368222756937311369240198571933653681461524869092))(Hash 1055801623879847096628433511678534132188122629115779973820670796633139586780)))(next_available_token 7)))(protocol_state_body((genesis_state_hash 7972428409254861556390111253648040251978614088739790308121422272802905213246)(blockchain_state((staged_ledger_hash((non_snark((ledger_hash 21789639496715580796923609659249828902764215186293592097668076570869067661747)(aux_hash"\155\242\214\217\252q\192\006\0210\016\152d\142\243\204V\237\022X\006\141\131\195\183\236\203\171\197\023\230\239")(pending_coinbase_aux"\000\141=\"\n\221\022.$\166\025g;\160\132\151\174e\1961\153W\171\r\001~r\003\204\210\\\004")))(pending_coinbase_hash 20078216432286369181111620543180517118563528017237812752726903457069258536973)))(snarked_ledger_hash 9531901115761935764758534987471432580407825852720663966824029456410684649371)(snarked_next_available_token 2)(timestamp 1600327640000)))(consensus_state((blockchain_length 111)(epoch_count 0)(min_window_density 160)(sub_window_densities(0 20 20 20 20 20 20 20))(last_vrf_output"G\025&~\229\186\002{{\188F\000;0\253\141\004\153\233!\020<\218\021\203\137\202\202\216\143\150\004")(total_currency 90982100000001000)(curr_global_slot((slot_number 313)(slots_per_epoch 480)))(staking_epoch_data((ledger((hash 9531901115761935764758534987471432580407825852720663966824029456410684649371)(total_currency 90982100000001000)))(seed 0)(start_checkpoint 0)(lock_checkpoint 0)(epoch_length 1)))(next_epoch_data((ledger((hash 9531901115761935764758534987471432580407825852720663966824029456410684649371)(total_currency 90982100000001000)))(seed 21792316436254650149327858098687852676553342335811966816389267041363881678203)(start_checkpoint 0)(lock_checkpoint 18129034016165038021433722489384175216853726787068625736021978501149574146563)(epoch_length 112)))(has_ancestor_in_same_checkpoint_window true)))(constants((k 20)(delta 3)(genesis_state_timestamp 1600271300000)))))(init_stack((data 23140642383725271192818829662423906112345096325302005775638625498385383088111)(state((init 18725600149482768702122737662018824018365718553036858974032547020773471844694)(curr 18725600149482768702122737662018824018365718553036858974032547020773471844694)))))(status(Failed Not_token_owner))))

…rror

…-snark-error" This reverts commit 6d25475, reversing changes made to fb80053.

…-env-var

netlify · 2020-09-18T18:00:56Z

Preview:

Built with commit 2ad05b1

https://deploy-preview-6036--o1website2.netlify.app

mrmr1993 and others added 18 commits September 18, 2020 02:24

Not_token_owner only fails for non-default tokens

0f325ea

Fix broken condition

fb80053

Manually pin ocamlgraph while ocamlgraph.lri.fr is down

1c9426e

Try pinning to the release archive instead

2fc4fb8

Install conf-autoconf before ocamlgraph

97d6032

Install autoconf

960581d

Merge branch 'fix/ocamlgraph-ci-for-release' into feature/fix-snark-e…

6d25475

…rror

snark coordinator in an env var

e9d85fe

improve robustness

a43414a

Revert "Merge branch 'fix/ocamlgraph-ci-for-release' into feature/fix…

4268589

…-snark-error" This reverts commit 6d25475, reversing changes made to fb80053.

use a file rather than env var

c35c1f7

add debug log

0e3c079

Do not fail if amount+fee overflows in non-fee-transfers

35d7535

Handle receiver overflows as an effective user command failure

4cb69f8

Merge branch 'feature/fix-snark-error' into feature/snark-coordinator…

7b0c22f

…-env-var

Merge branch 'master' into feature/snark-coordinator-env-var

42aee35

Merge branch 'fix/overflows' into feature/release-fixes

955b922

mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Sep 18, 2020

mrmr1993 requested a review from bkase September 18, 2020 17:51

mrmr1993 requested a review from a team as a code owner September 18, 2020 17:51

Merge branch 'master' into feature/release-fixes

2ad05b1

bkase merged commit 2ad05b1 into master Sep 18, 2020

bkase deleted the feature/release-fixes branch September 18, 2020 18:00

This was referenced Sep 19, 2020

Crashing report - Testnet 3.3 - Docker - Ducca#5707 #5985

Closed

Crash Report - Testnet 3.3 - CrisF#3405 #5984

Closed

Coda daemon crased #5981

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for release #6036

Fixes for release #6036

mrmr1993 commented Sep 18, 2020

netlify bot commented Sep 18, 2020

Fixes for release #6036

Fixes for release #6036

Conversation

mrmr1993 commented Sep 18, 2020

netlify bot commented Sep 18, 2020