Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Fix overflows in the transaction snark #6034

Merged
merged 2 commits into from
Sep 18, 2020
Merged

[Release] Fix overflows in the transaction snark #6034

merged 2 commits into from
Sep 18, 2020

Conversation

mrmr1993
Copy link
Member

This PR

  • swallows an overflow error that can't affect user commands, fixing Snark worker crashes #6028
  • handles the other possible overflow location in line with what's done in the transaction logic
  • adds a TODO for later reference.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 requested a review from a team as a code owner September 18, 2020 17:26
@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Sep 18, 2020
@mrmr1993 mrmr1993 changed the title Fix overflows in the transaction snark [Release] Fix overflows in the transaction snark Sep 18, 2020
@mrmr1993 mrmr1993 mentioned this pull request Sep 18, 2020
Merged
5 tasks
@bkase bkase merged commit 955b922 into master Sep 18, 2020
@bkase bkase deleted the fix/overflows branch September 18, 2020 18:00
@mrmr1993 mrmr1993 mentioned this pull request Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @bkase