Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] Token Productization Docs #5754

Merged
merged 7 commits into from
Aug 25, 2020
Merged

[Website] Token Productization Docs #5754

merged 7 commits into from
Aug 25, 2020

Conversation

MartinMinkov
Copy link
Contributor

This PR adds the docs page that will be used for tokens.

@MartinMinkov MartinMinkov requested a review from a team as a code owner August 25, 2020 16:14
@MartinMinkov MartinMinkov linked an issue Aug 25, 2020 that may be closed by this pull request
@MartinMinkov MartinMinkov added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR labels Aug 25, 2020
@netlify
Copy link

netlify bot commented Aug 25, 2020

Preview:

Built with commit 56f48d0

https://deploy-preview-5754--o1website2.netlify.app

@MartinMinkov MartinMinkov added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR and removed ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR labels Aug 25, 2020
@mergify mergify bot merged commit 73e8729 into develop Aug 25, 2020
@mergify mergify bot deleted the docs/tokens branch August 25, 2020 17:10

When creating a new token, a new token ID is created as well as a token account for your public key. This token account owns the token and can mint more of the token. The account will also (eventually) have the power to enable/disable accounts, and to set whether new accounts may be created for the token.

Please note that creating new tokens requires an additional fee on top of the ever-present transaction fee. This additional fee is the fee that must be paid when creating a new token account. This means there is a fee for the account creation on top of the transaction fee that is normally applied.
Copy link
Contributor

@garethtdavies garethtdavies Aug 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we state what this is? It seems to be 1 on the latest implementation?


- -**receiver** : The public key to create the new account for, you can reuse your normal public key here

- -**sender** : The public key for which you want to create the account
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is confusing as sender seems to be the same as the receiver. As per the help isn't this Public key from which you want to send the transaction and is equivalent to feePayer in GraphQL

@garethtdavies
Copy link
Contributor

Oops, just realized this was already merged 😕

@figitaki
Copy link
Contributor

This is good feedback though, I'll open up a follow on.

@garethtdavies
Copy link
Contributor

garethtdavies commented Aug 27, 2020

I'll also add this here but there should also be a section named "Sending Tokens" that details how to send between token accounts by using coda client send-payment and specifying the -token.

@ghost
Copy link

ghost commented Aug 27, 2020

haha i have a feeling this will be fun 🥇

@cryptoenthu1
Copy link

cryptoenthu1 commented Aug 27, 2020

frontend/website/pages/docs/tokens.mdx
Line number 10 : With the CLI, you are able to create your own tokens on Coda. Non-default tokens are a new type of token that is introduced to the Coda blockchain.

If any GUI related information there "for the ability to create your own tokens on Coda" , can that GUI related information also be added here ? Just a thought, please ignore if this is irrelevant here.

My Discord Id : Naga#0916

@MartinMinkov
Copy link
Contributor Author

I'll also add this here but there should also be a section named "Sending Tokens" that details how to send between token accounts by using coda client send-payment and specifying the -token.

That's a great suggestion and I was thinking the same thing as I was running through the docs on my own. Thanks for bringing this to light, I will add this section asap! Thanks garethtdavies!

@ilhamm02
Copy link

I suggest adding the details contained in the command create a new token. like what are public-key, key, and token_id so that this becomes clear, especially for beginners like me :D. And also maybe you can add how to view the list of tokens that have been previously created.

Oh yes, you might also add details about how much the costs are needed.

Discord OkeSip#7763

@MichaelStephen2428
Copy link

MichaelStephen2428 commented Aug 28, 2020

Can we get a coda client list balance for more detailed information regarding the token balance of non-default tokens and associated token accounts, like in a list format ?

Discord ID: Michael Stephen#5883

@MartinMinkov
Copy link
Contributor Author

hey everyone. thank you for your feedback. I have added an Example section in this PR:

#5789

I have added examples of how to create, mint, and send a new token. There are a few new commands to view your balance for new tokens, please see the example section for more info. Please let me know if there is anything else you would like to see added.

@Cris-F
Copy link

Cris-F commented Aug 29, 2020

Hi, CrisF#3405 from Discord here. Having a look through as requested in the discord announcement.

Like the doc, it is easily readable. Have made some small suggestions for consideration.

(line 10)
Wondering, should Non-default tokens are a new type of token that is introduced... be ... have been introduced...? (with have been replacing is?)

(line 14)
...ever-present... is clearly understandable but might have a negative connotation (?). Possibly replace with normal or something similar?

(line 57 & 58)
Agree with garethtdavies here. I found this confusing also.

(line 88 & 94)
The sender and receiver are very clear here.

Cheers

Copy link

@ZerglingSC ZerglingSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey guys, @toma#652 from Discord here.

I am so excited about Coda and being able to issue tokens easily on it sounds even more exciting. Unfortunately I am not a tech guy and can comment on the technical part below, but wanted to give you a hint from another project I am following closely - Nervos. They created something called CKB Studio that (my understanding is) would allow for easily creating tokens via an interface that even non-tech guys could utilise - here is a Medium link with a tutorial: https://medium.com/nervos-ckb-israel/minting-custom-tokens-with-ckb-studio-3354783acb38

Is this something that could be done on Coda and would make sense for you?

And another question: why do you go for a new type of token (non-default tokens) and what are NDT's benefits compared to tokens issued on other blockchains?

All the best.

@ghost
Copy link

ghost commented Aug 29, 2020

can you get other chains to use coda proofs much easier, more simpler

@evstigneeff
Copy link

evstigneeff commented Aug 30, 2020

Another one suggestion would be to clarify what these non-default tokens are for. Possible use cases, etc.
My Discord id is evstigneeff#9201

@Jmunb
Copy link

Jmunb commented Sep 1, 2020

Most likely, users who will find themselves on this page are technically quite savvy, I think it will not be superfluous to give general concepts of the token and its properties. Also, a user who has come to this page may be in a state of choosing a blockchain for their needs, and it will be appropriate to tell him why tokens may be needed, give him a list of token strengths, differences from popular similar technologies on the market and examples of their use.

It would also be interesting to add a sandbox next to the examples so that the user can create and send tokens, thereby gaining experience in using tokens in the coda system.

The following commands may also be useful to the user:

  • Get a list of non-standard coins
  • Delete token account
  • Burn tokens

My Discord id is Jmunb#6752

@wufangfang1984
Copy link

cli链接无效
mint-token链接无效

Two links as shown in above pictures not work.

My discord id: wufangfang#5228

Thanks.

@LanceGooding
Copy link

Looks good!

Gooding #5670

@48cfu
Copy link

48cfu commented Sep 3, 2020

What about stable token support? Let's say I have some stable token 1 and 2(ST1 and ST2). I would like to deposit some money into ST1, automatically transfers it to ST2. When I withdraw from ST1, this should automatically convert ST2 into ST1 and then withdraw. Could I achieve something like this?
My discord is RealBlackCelsius#1861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tokens productization