Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] Token Productization Docs #5575

Closed
wants to merge 6 commits into from
Closed

[Website] Token Productization Docs #5575

wants to merge 6 commits into from

Conversation

MartinMinkov
Copy link
Contributor

This PR adds the docs page that will be used for tokens.

@MartinMinkov MartinMinkov requested a review from a team as a code owner August 5, 2020 20:49
@MartinMinkov MartinMinkov linked an issue Aug 5, 2020 that may be closed by this pull request
@MartinMinkov MartinMinkov added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Aug 5, 2020
@netlify
Copy link

netlify bot commented Aug 5, 2020

Preview:

Built with commit 56f48d0

https://deploy-preview-5575--o1website2.netlify.app


Using the Coda CLI (command-line interface) is the primary way to create new token accounts, create new tokens, and mint tokens on the Coda blockchain.

In this section, you will find out how to use the Coda CLI to create new tokens, create new token accounts, and mint non-default tokens!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is a little repetitive given the prior one. Can we combine these somehow?


## Creating Tokens

With the CLI, you are able to create your own layer 2 tokens! Layer 2 tokens are a new type of token that is introduced to the Coda blockchain. These new types of tokens have a unique identifier that differentiate them from all other tokens in the blockchain. Users with an associated token account can then receive/send this new type of token that is totally separate from the native Coda token itself! When you create a new token, you are then able to mint more of the token to be used (see below in Minting Tokens).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to avoid the language "layer 2 tokens" because people may get confused that this is similar to a layer-2 protocol. Can we call this "tokens on Coda"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Make "Minting Tokens" a link

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: please update "layer 2 tokens" elsewhere in the doc as well.

When creating a new token, a new token ID is created as well as a token account public key. This token account owns the token and can mint more of the token. The account will also (eventually) have the power to enable/disable accounts, and to set whether new accounts may be created for the token.


There is a fee to create a new token. The fee is the amount you are willing to pay to process the transaction. If this flag is not specified, the default value is 5 Coda. Additionally, the fee for creating the new token account is charged in addition to the transaction fee.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the first sentence so as to not bury the lede as much? Maybe: "Creating new tokens requires an additional fee on top of the ever-present transaction fee"


<Alert>

The CLI requires that the token-owner to be passed explicitly. If the token owner is not given, the CLI will query to find the token owner. If no owner is found, the command will fail with an error.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The CLI doesn't require the token-owner be passed explicitly (otherwise we wouldn't need a default)


## Creating Token Accounts

With the CLI, you are able to create a token account for existing tokens. Token accounts are like regular accounts but solely meant to interact with the layer 2 tokens that exist in the Coda protocol. There is a unique token account for each type of token you wish to interact with.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a unique token account for each type of token you wish to interact with.

You must create a separate unique token account for each type of token you wish to interact with

Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a once-over to check the details. Looks good, but left a handful of nits (sorry!)

@MartinMinkov
Copy link
Contributor Author

!ci-build-me

@MartinMinkov MartinMinkov removed the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Aug 25, 2020
@MartinMinkov
Copy link
Contributor Author

moved too #5754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tokens productization
5 participants