Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hex {en,de}coding for arbitrary bytes #5686

Merged
merged 3 commits into from
Aug 20, 2020
Merged

Hex {en,de}coding for arbitrary bytes #5686

merged 3 commits into from
Aug 20, 2020

Conversation

bkase
Copy link
Member

@bkase bkase commented Aug 18, 2020

ASCII hex encoding and decoding of bytes (as represented by string). Needed for several Rosetta serialization routines.

@bkase bkase requested a review from a team as a code owner August 18, 2020 18:24
@bkase bkase added ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR ci-build-me Add this label to trigger a circle+buildkite build for this branch labels Aug 18, 2020
@psteckler
Copy link
Member

@bkase There's an existing Hex in src/lib/hex/.

Should these live in one place?

@bkase
Copy link
Member Author

bkase commented Aug 19, 2020

@psteckler Ahh how did I miss this!

@psteckler psteckler removed the ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR label Aug 19, 2020
@bkase bkase added the ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR label Aug 19, 2020
@bkase
Copy link
Member Author

bkase commented Aug 19, 2020

I moved my implementation under the Safe submodule of hex.ml since it's (more) safe against maliciously crafted input, plus made #5711 so we can dedupe these implementations at some point.

@netlify
Copy link

netlify bot commented Aug 19, 2020

Preview:

Built with commit 4b15537

https://deploy-preview-5686--o1website2.netlify.app

@mergify mergify bot merged commit de00932 into develop Aug 20, 2020
@mergify mergify bot deleted the hex-encoding-decoding branch August 20, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

@psteckler psteckler psteckler approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkase @psteckler @mrmr1993