-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reland Reland "Port DW Pose preprocessor" #1892
Conversation
* ➕ Add dependencies * 🚧 wip * 🚧 wip * 🚧 download models * 🚧 Minor fixes * 🔧 update gitignore * 🐛 Fix normalization issue * 🚧 load DW model only when DW preprocessor is selected * ✅ Change test config * 🎨 nits * 🐛 Fix A1111 safe torch issue 📝 v1.1.235 (#1859) Revert "Port DW Pose preprocessor (#1856)" (#1860) This reverts commit 0d3310f. Reland "Port DW Pose preprocessor" (#1861) * Revert "Revert "Port DW Pose preprocessor (#1856)" (#1860)" This reverts commit 17e100e. * 🐛 Fix install.py 📝 v1.1.236 (#1862) :bug: Delay import of mmpose (#1866) :memo: v1.1.237 (#1868) :bug: Fix all keypoints invalid issue (#1871) :bug: lazy import :construction: update test expectation :construction: Switch to onnx :construction: solve onnx package issue :wrench: Check cuda in more efficient way :art: Format code :wrench: Make onnx runtime optional
where is the onnx dependency? does webui has onnx in it? or pytorch has onnx in it? |
ah nvm. just find out check_onnx_environment(): |
WebUI only has 1 onnx ref on a non-essential feature: The onnx environment check code comes from diffusers implementation: I don't think opencv depends on onnx right now. Searching |
but some people seem to claim that opencv dnn (cv2.dnn) can read and infer onnx on cpu |
FYI, cv2.dnn API that seems to read ONNX model: https://docs.opencv.org/4.8.0/d6/d0f/group__dnn.html#ga7faea56041d10c71dbbd6746ca854197 |
We support to run onnx model with opencv in branch opencv_onnx. But we need to manually build OpenCV through cmake to work with GPU. However, according to our test, the speed is also fine with CPU. |
got error when using opencv 4.5.5:
upgrade to 4.8.0 then everything went fine |
* Port DW Pose preprocessor (Mikubill#1856) * ➕ Add dependencies * 🚧 wip * 🚧 wip * 🚧 download models * 🚧 Minor fixes * 🔧 update gitignore * 🐛 Fix normalization issue * 🚧 load DW model only when DW preprocessor is selected * ✅ Change test config * 🎨 nits * 🐛 Fix A1111 safe torch issue 📝 v1.1.235 (Mikubill#1859) Revert "Port DW Pose preprocessor (Mikubill#1856)" (Mikubill#1860) This reverts commit 0d3310f. Reland "Port DW Pose preprocessor" (Mikubill#1861) * Revert "Revert "Port DW Pose preprocessor (Mikubill#1856)" (Mikubill#1860)" This reverts commit 17e100e. * 🐛 Fix install.py 📝 v1.1.236 (Mikubill#1862) :bug: Delay import of mmpose (Mikubill#1866) :memo: v1.1.237 (Mikubill#1868) :bug: Fix all keypoints invalid issue (Mikubill#1871) :bug: lazy import :construction: update test expectation :construction: Switch to onnx :construction: solve onnx package issue :wrench: Check cuda in more efficient way :art: Format code :wrench: Make onnx runtime optional * Use cv2 to load and run model on cpu * nit
Relands #1890.
This PR now makes onnx runtime optional. (Not forcing user to install it on startup)