-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Delay import of mmpose #1866
Merged
Merged
🐛 Delay import of mmpose #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
added a commit
that referenced
this pull request
Aug 5, 2023
* ➕ Add dependencies * 🚧 wip * 🚧 wip * 🚧 download models * 🚧 Minor fixes * 🔧 update gitignore * 🐛 Fix normalization issue * 🚧 load DW model only when DW preprocessor is selected * ✅ Change test config * 🎨 nits * 🐛 Fix A1111 safe torch issue 📝 v1.1.235 (#1859) Revert "Port DW Pose preprocessor (#1856)" (#1860) This reverts commit 0d3310f. Reland "Port DW Pose preprocessor" (#1861) * Revert "Revert "Port DW Pose preprocessor (#1856)" (#1860)" This reverts commit 17e100e. * 🐛 Fix install.py 📝 v1.1.236 (#1862) :bug: Delay import of mmpose (#1866) :memo: v1.1.237 (#1868) :bug: Fix all keypoints invalid issue (#1871) :bug: lazy import
huchenlei
added a commit
that referenced
this pull request
Aug 7, 2023
* ➕ Add dependencies * 🚧 wip * 🚧 wip * 🚧 download models * 🚧 Minor fixes * 🔧 update gitignore * 🐛 Fix normalization issue * 🚧 load DW model only when DW preprocessor is selected * ✅ Change test config * 🎨 nits * 🐛 Fix A1111 safe torch issue 📝 v1.1.235 (#1859) Revert "Port DW Pose preprocessor (#1856)" (#1860) This reverts commit 0d3310f. Reland "Port DW Pose preprocessor" (#1861) * Revert "Revert "Port DW Pose preprocessor (#1856)" (#1860)" This reverts commit 17e100e. * 🐛 Fix install.py 📝 v1.1.236 (#1862) :bug: Delay import of mmpose (#1866) :memo: v1.1.237 (#1868) :bug: Fix all keypoints invalid issue (#1871) :bug: lazy import
huchenlei
added a commit
that referenced
this pull request
Aug 7, 2023
* Port DW Pose preprocessor (#1856) * ➕ Add dependencies * 🚧 wip * 🚧 wip * 🚧 download models * 🚧 Minor fixes * 🔧 update gitignore * 🐛 Fix normalization issue * 🚧 load DW model only when DW preprocessor is selected * ✅ Change test config * 🎨 nits * 🐛 Fix A1111 safe torch issue 📝 v1.1.235 (#1859) Revert "Port DW Pose preprocessor (#1856)" (#1860) This reverts commit 0d3310f. Reland "Port DW Pose preprocessor" (#1861) * Revert "Revert "Port DW Pose preprocessor (#1856)" (#1860)" This reverts commit 17e100e. * 🐛 Fix install.py 📝 v1.1.236 (#1862) :bug: Delay import of mmpose (#1866) :memo: v1.1.237 (#1868) :bug: Fix all keypoints invalid issue (#1871) :bug: lazy import * :construction: update test expectation * :construction: Switch to onnx * :construction: solve onnx package issue * :wrench: Check cuda in more efficient way * :art: Format code
huchenlei
added a commit
that referenced
this pull request
Aug 7, 2023
* ➕ Add dependencies * 🚧 wip * 🚧 wip * 🚧 download models * 🚧 Minor fixes * 🔧 update gitignore * 🐛 Fix normalization issue * 🚧 load DW model only when DW preprocessor is selected * ✅ Change test config * 🎨 nits * 🐛 Fix A1111 safe torch issue 📝 v1.1.235 (#1859) Revert "Port DW Pose preprocessor (#1856)" (#1860) This reverts commit 0d3310f. Reland "Port DW Pose preprocessor" (#1861) * Revert "Revert "Port DW Pose preprocessor (#1856)" (#1860)" This reverts commit 17e100e. * 🐛 Fix install.py 📝 v1.1.236 (#1862) :bug: Delay import of mmpose (#1866) :memo: v1.1.237 (#1868) :bug: Fix all keypoints invalid issue (#1871) :bug: lazy import :construction: update test expectation :construction: Switch to onnx :construction: solve onnx package issue :wrench: Check cuda in more efficient way :art: Format code :wrench: Make onnx runtime optional
huchenlei
added a commit
that referenced
this pull request
Aug 9, 2023
* Port DW Pose preprocessor (#1856) * ➕ Add dependencies * 🚧 wip * 🚧 wip * 🚧 download models * 🚧 Minor fixes * 🔧 update gitignore * 🐛 Fix normalization issue * 🚧 load DW model only when DW preprocessor is selected * ✅ Change test config * 🎨 nits * 🐛 Fix A1111 safe torch issue 📝 v1.1.235 (#1859) Revert "Port DW Pose preprocessor (#1856)" (#1860) This reverts commit 0d3310f. Reland "Port DW Pose preprocessor" (#1861) * Revert "Revert "Port DW Pose preprocessor (#1856)" (#1860)" This reverts commit 17e100e. * 🐛 Fix install.py 📝 v1.1.236 (#1862) :bug: Delay import of mmpose (#1866) :memo: v1.1.237 (#1868) :bug: Fix all keypoints invalid issue (#1871) :bug: lazy import :construction: update test expectation :construction: Switch to onnx :construction: solve onnx package issue :wrench: Check cuda in more efficient way :art: Format code :wrench: Make onnx runtime optional * Use cv2 to load and run model on cpu * nit
tiangles
pushed a commit
to diffus-me/sd-webui-controlnet
that referenced
this pull request
Aug 18, 2023
tiangles
pushed a commit
to diffus-me/sd-webui-controlnet
that referenced
this pull request
Aug 18, 2023
* Port DW Pose preprocessor (Mikubill#1856) * ➕ Add dependencies * 🚧 wip * 🚧 wip * 🚧 download models * 🚧 Minor fixes * 🔧 update gitignore * 🐛 Fix normalization issue * 🚧 load DW model only when DW preprocessor is selected * ✅ Change test config * 🎨 nits * 🐛 Fix A1111 safe torch issue 📝 v1.1.235 (Mikubill#1859) Revert "Port DW Pose preprocessor (Mikubill#1856)" (Mikubill#1860) This reverts commit 0d3310f. Reland "Port DW Pose preprocessor" (Mikubill#1861) * Revert "Revert "Port DW Pose preprocessor (Mikubill#1856)" (Mikubill#1860)" This reverts commit 17e100e. * 🐛 Fix install.py 📝 v1.1.236 (Mikubill#1862) :bug: Delay import of mmpose (Mikubill#1866) :memo: v1.1.237 (Mikubill#1868) :bug: Fix all keypoints invalid issue (Mikubill#1871) :bug: lazy import * :construction: update test expectation * :construction: Switch to onnx * :construction: solve onnx package issue * :wrench: Check cuda in more efficient way * :art: Format code
tiangles
pushed a commit
to diffus-me/sd-webui-controlnet
that referenced
this pull request
Aug 18, 2023
* Port DW Pose preprocessor (Mikubill#1856) * ➕ Add dependencies * 🚧 wip * 🚧 wip * 🚧 download models * 🚧 Minor fixes * 🔧 update gitignore * 🐛 Fix normalization issue * 🚧 load DW model only when DW preprocessor is selected * ✅ Change test config * 🎨 nits * 🐛 Fix A1111 safe torch issue 📝 v1.1.235 (Mikubill#1859) Revert "Port DW Pose preprocessor (Mikubill#1856)" (Mikubill#1860) This reverts commit 0d3310f. Reland "Port DW Pose preprocessor" (Mikubill#1861) * Revert "Revert "Port DW Pose preprocessor (Mikubill#1856)" (Mikubill#1860)" This reverts commit 17e100e. * 🐛 Fix install.py 📝 v1.1.236 (Mikubill#1862) :bug: Delay import of mmpose (Mikubill#1866) :memo: v1.1.237 (Mikubill#1868) :bug: Fix all keypoints invalid issue (Mikubill#1871) :bug: lazy import :construction: update test expectation :construction: Switch to onnx :construction: solve onnx package issue :wrench: Check cuda in more efficient way :art: Format code :wrench: Make onnx runtime optional * Use cv2 to load and run model on cpu * nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have reported having problem installing
mmpose
which is required by DW Pose. This PR delays the import of mmpose to the actual run ofdw_openposefull_preprocessor
, so that other parts of ControlNet still remains functional even when DW Pose has some problems installing dependencies.#1864
#1865