Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PowerToys] Run page: Additional updates and improvements #3768

Merged
merged 8 commits into from
Apr 11, 2022
Merged

[PowerToys] Run page: Additional updates and improvements #3768

merged 8 commits into from
Apr 11, 2022

Conversation

htcfreek
Copy link
Contributor

@htcfreek htcfreek commented Apr 4, 2022 •
edited
Loading

This PR adds/changes the following:

MERGE HINT:
Please don't merge before an approval of @Jay-o-Way and @jaimecbernardo!!

@PRMerger14
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger13 PRMerger13 requested a review from mattwojo April 4, 2022 20:27
htcfreek
htcfreek commented Apr 4, 2022
View reviewed changes
Copy link
Contributor Author

@htcfreek htcfreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes for reviewers.

hub/powertoys/run.md Outdated Show resolved Hide resolved
hub/powertoys/run.md Outdated Show resolved Hide resolved
hub/powertoys/run.md Show resolved Hide resolved
hub/powertoys/run.md Show resolved Hide resolved
hub/powertoys/run.md Show resolved Hide resolved
@PRMerger17
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@htcfreek htcfreek marked this pull request as ready for review April 4, 2022 20:44
@Jak-MS Jak-MS added the aq-pr-triaged tracking label for the PR review team label Apr 4, 2022
@mattwojo mattwojo mentioned this pull request Apr 5, 2022
Closed
jaimecbernardo
jaimecbernardo approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, but other than that, LGTM!
Thank you for the contribution!

hub/powertoys/run.md Outdated Show resolved Hide resolved
hub/powertoys/run.md Outdated Show resolved Hide resolved
Jay-o-Way
Jay-o-Way suggested changes Apr 5, 2022
View reviewed changes
hub/powertoys/run.md Outdated Show resolved Hide resolved
hub/powertoys/run.md Outdated Show resolved Hide resolved
hub/powertoys/run.md Show resolved Hide resolved
hub/powertoys/run.md Outdated Show resolved Hide resolved
hub/powertoys/run.md Outdated Show resolved Hide resolved
hub/powertoys/run.md Show resolved Hide resolved
Jay-o-Way
Jay-o-Way suggested changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@Jay-o-Way Jay-o-Way left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 more

hub/powertoys/run.md Outdated Show resolved Hide resolved
@Jay-o-Way
Copy link
Contributor

@mattwojo I see now that in the no-loc section, "File Explorer" is included. But in Windows, this app is translated. Shouldn't we use the localized name for consistency?

@htcfreek

This comment was marked as resolved.

Sign in to view
@PRMerger16
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger5
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger9
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@htcfreek
Copy link
Contributor Author

htcfreek commented Apr 9, 2022

@jaimecbernardo , @Jay-o-Way
Can you please review again. Thank you.

@PRMerger7
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger8
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger18
Copy link
Contributor

@htcfreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Jay-o-Way
Copy link
Contributor

Aside for that letter P thing; looking good! 👍🏻😄

@htcfreek
Copy link
Contributor Author

@jaimecbernardo
Can you please review. I like to get this in now.

jaimecbernardo
jaimecbernardo approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@htcfreek
Copy link
Contributor Author

@mattwojo
This can get in now.

@mattwojo mattwojo merged commit eb95680 into MicrosoftDocs:docs Apr 11, 2022
@htcfreek htcfreek deleted the PtDocs2 branch April 11, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jay-o-Way Jay-o-Way Jay-o-Way requested changes

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

@mattwojo mattwojo Awaiting requested review from mattwojo

Assignees

@mattwojo mattwojo

Labels
aq-pr-triaged tracking label for the PR review team Change sent to author dev-environment/prod do-not-merge powertoys/tech PowerToys docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.