[PT Run] Calculator: rand() return float instead of int

[htcfreek]

Microsoft PowerToys version

0.56.2

Running as admin

• Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

type rand().

✔️ Expected Behavior

An integer is returned.

❌ Actual Behavior

Other Software

No response

[htcfreek]

duplicate of #17300

[htcfreek]

Sorry I closed this mistakenly. It isn't a duplicate.

[jaimecbernardo]

I think returning a number between 0 and 1 is pretty common for random functions.
Seems to be working as expected by the engine's documentation as well: https://github.com/FlorianRappl/Mages/blob/6e283ae40f9fb21137a3e339778629563cbda719/doc/functions.md#generate-single-random-number

[htcfreek]

Hmmm. Didn't know that.

[htcfreek]

I think we should have a second operation to return it as int with a custom count of digits. Something like ranint(5).

[jaimecbernardo]

Marking it as an enhancement. Though I wonder if it's possible before changing engine.

[htcfreek]

Marking it as an enhancement. Though I wonder if it's possible before changing engine.

It might be a way to only cut 0, from the result in a first step.

[Jay-o-Way]

Both integer and floating are welcome. Sould use 2 different keywords, like @htcfreek mentioned RandInt. --> Rename this issue?

I think we should have a second operation to return it as int with a custom count of digits. Something like ranint(5).

RandInt(5) is also used/interpreted for an integer between 0 and 5.
Decimal variable might be added to the other one: rand(5) => 0,10125.

[jaimecbernardo]

I think this needs to be done on the engine we're using though, which is an open source Calculator Engine. Or be referenced in the issue about changing calculator engine as a requirement.

[jaimecbernardo]

For reference, here's the calculator engine:
https://www.nuget.org/packages/Mages/
https://github.com/FlorianRappl/Mages/

[jaimecbernardo]

@Jay-o-Way , can you please link to it?

[htcfreek]

@Jay-o-Way , can you please link to it?

@jaimecbernardo
The pr is closed because it conflicts with my planned changes. But the hotfixes had higher prio for me. I will cover this in me pr that hopefully gets ready this week. ( Then I ping you both.)

[GhostVaibhav]

Hi @htcfreek, should we close this issue? Or, do we still need a function for generating random integers?

[htcfreek]

@GhostVaibhav
It still does not exist. Do you like to implement it?

[GhostVaibhav]

@htcfreek Count me in 👍🏻

[GhostVaibhav]

Hi @htcfreek, some doubts. Would it be easier if rather than handling this request on our end, we handled it on Mages' end? What I meant to say is should I add randInt() implementation on Mages and update the repo's version here, or should I handle it here itself?

[htcfreek]

Hi @htcfreek, some doubts. Would it be easier if rather than handling this request on our end, we handled it on Mages' end? What I meant to say is should I add randInt() implementation on Mages and update the repo's version here, or should I handle it here itself?

The faster solution would be handle in PT Run.

But you can ask to implement it in mages. Not sure if it will get in there.

[GhostVaibhav]

The PT Run is a very hacky way of getting this done. What I was thinking,

1. Match the number inside randInt(342), in this 342 would be matched. Also, replace it with an empty string.
2. Replace randInt() with "Round($matchedNumber * rand())"

Does this sound good?

[htcfreek]

After thinking again we should first open an issue an maybe a PR on mages repository as this would be the correct way. If the issue/PR not gets accepted, we can implement it in our plugin using a hacky way.

[GhostVaibhav]

Hi @htcfreek, I have raised a PR on the Mages repo. Links to follow -

• Added a randi() function to generate random integers FlorianRappl/Mages#124

But, I have one concern, it's listed under the v3.0.0 milestone and so are the 3 other issues. It would take additional time to get them fixed. So, they are inadvertently blocking the release of this feature. Any suggestions?

[htcfreek]

But, I have one concern, it's listed under the v3.0.0 milestone and so are the 3 other issues. It would take additional time to get them fixed. So, they are inadvertently blocking the release of this feature. Any suggestions?

That's what I had feared.

We could asked the repository maintainer if it is possible to backport the feature into v2.x release.

[GhostVaibhav]

Hi @htcfreek, good news. The PR got merged just now. What should be the next course of action? Should we ping the maintainer for a release?

[htcfreek]

Hi @htcfreek, good news. The PR got merged just now. What should be the next course of action?

Great news.

Should we ping the maintainer for a release?

Yes, I think we can friendly ask for a time plan. I would reference to the PowerToys repository.

[NoPlagiarism]

V3.0.0 is out

[GhostVaibhav]

Hi @htcfreek, the latest version of Mages has been released. Included with it is the new randi() function. I'm a little out of touch with the current repo. Can you take it from here?

[htcfreek]

@GhostVaibhav
Is it correct that we only have to update the mages package version and documentation?

[GhostVaibhav]

@htcfreek
Correct

[htcfreek]

@GhostVaibhav
Can take a look in the next days.