Skip to content
This repository has been archived by the owner on May 2, 2020. It is now read-only.

don't import Markdown in 0.4 #34

Closed
wants to merge 1 commit into from
Closed

Conversation

hayd
Copy link
Contributor

@hayd hayd commented Mar 12, 2015

fixes #28

There's still one issue with using help e.g.

julia> import Lexicon

help?> Lexicon  # expect to print README
search: Lexicon

INFO: Parsing documentation for Docile.Interface.
INFO: Parsing documentation for Lexicon.
INFO: Parsing documentation for Docile.

Note: actually also [text][ref] syntax isn't supported yet, and I was getting an EOF error with your Lexicon's readme file (will see if I can reproduce...).

fix test that uses BlockCode which is no longer in Markdown

fix Markdown.Code not defined in 0.3
@MichaelHatherly
Copy link
Owner

Thanks @hayd. I think it would be preferable to not need the try catch block for this.

@one-more-minute are there plans to backport the work that's been done in Base to Markdown.jl? If not we could just pull in all the markdown-related code from Base and not require Markdown.jl – I'm fine with either option.

That EOF error from trying to display the readme is probably the reason I didn't get round to supporting automatically displaying a package's readme, if I remember correctly. Shouldn't be much of a problem getting that working once we resolve the EOF error.

@hayd
Copy link
Contributor Author

hayd commented Mar 12, 2015

@MichaelHatherly The only other thing is named links, which aren't supported in Markdown yet (but I think they are part of the commonmark spec).

Yeah the try-catch is a band aid... I was surprised this was needed as BlockCode is no longer in Markdown.jl repo (is it just past due a release)?

@MichaelHatherly
Copy link
Owner

Yeah, looks like a new tag would be enough. After that just isa(block, Code) would be sufficient and setting the minimum version of Markdown.jl in the REQUIRES file correctly.

@hayd
Copy link
Contributor Author

hayd commented Mar 27, 2015

Shouldn't be much of a problem getting that working once we resolve the EOF error.

As mentioned over at julia, the EOF issue is fixed in master :)

(This PR is still waiting on the Markdown tag release... and me removing the special casing.)

@MichaelHatherly
Copy link
Owner

Until Markdown.jl is tagged I've backported the code from Base to deps/Markdown and added a conditional import for it. Once a tag is made I'll move back to requiring the package.

Ref: 1109796

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If julia > 0.3 don't require Markdown
2 participants