Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag new release. #21

Open
MichaelHatherly opened this issue Mar 12, 2015 · 9 comments
Open

Tag new release. #21

MichaelHatherly opened this issue Mar 12, 2015 · 9 comments

Comments

@MichaelHatherly
Copy link
Contributor

Are there any outstanding issues preventing a new release being tagged? Happy to have go at resolving them if necessary.

Ref: MichaelHatherly/Lexicon.jl#34

@hayd
Copy link

hayd commented Mar 12, 2015

Should import Markdown just import Base.Markdown on v0.4-? That'd solve different Markdown and Base.Markdown being potentially different. (I think it'll also make it easier to depreciate Markdown.jl - for 0.5 warn to suggest using Base.Markdown instead)

@hayd
Copy link

hayd commented Mar 12, 2015

There's been quite a few updates to Markdown - good thing is you can just paste from Base (I think?). There's a couple of PRs pending (horizontalrules and h4+) which may be worth waiting for.

Is it legal to do something like:

if VERSION >= v"0.4-"
    module Markdown
        using Base.Markdown
    end
else
module Markdown .... # all the code

Edit: or better yet

if VERSION >= v"0.4-"
    Markdown = Base.Markdown
else
module Markdown .... # all the code

Edit2: Well, neither of them work, not sure why/how to correct... :(

@MikeInnes
Copy link
Contributor

Yup, Markdown.jl is definitely overdue for an update. I have a backlog of PRs to go over (which is always nice) but once they're done I'll copy the code over.

Dates.jl has been through the exact same process so we can just copy whatever they did, in terms of compatibility.

@shashi
Copy link

shashi commented May 7, 2015

Bump! Need this to tag a release of Escher.

@MikeInnes
Copy link
Contributor

Apologies for not being particularly responsive on this – is there any chance someone could send a PR that brings things up to date? It should just be a case of copying the code from Base wholesale, then un-making any 0.4 breaking changes. If the patches are a separate commit it should be easy to reapply them in future.

@MichaelHatherly
Copy link
Contributor Author

I've backported Markdown into the Lexicon repo and have some time today that I could possibly use to do that.

@MichaelHatherly
Copy link
Contributor Author

Would you want 2-space or 4-space indentation? I'd think 4-space so that further updates are a bit easier.

@MikeInnes
Copy link
Contributor

Ha yeah, don't worry about re-indenting everything :)

@MichaelHatherly
Copy link
Contributor Author

Ref: #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants