Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Markdown from Julia 0.4. #23

Merged
merged 1 commit into from
May 8, 2015
Merged

Backport Markdown from Julia 0.4. #23

merged 1 commit into from
May 8, 2015

Conversation

MichaelHatherly
Copy link
Contributor

For conditionally importing the module in 0.3 I've been using

if VERSION < v"0.4-dev+1488"
    include("../deps/Markdown/src/Markdown.jl")
    import .Markdown
end

Trying to put the condition inside the Markdown module itself was giving me some trouble. Any ideas on how best to conditionally import or is this sufficient?

@MichaelHatherly
Copy link
Contributor Author

Hold on a moment, forgot to change the REQUIRES.

@MichaelHatherly
Copy link
Contributor Author

Should be fine now. Swapped out Lazy for Compat.

@MikeInnes
Copy link
Contributor

Thanks! I don't think it's worth worrying about conditionally importing on 0.4 too much, the only ways I can think of doing it are overly messy.

MikeInnes added a commit that referenced this pull request May 8, 2015
@MikeInnes MikeInnes merged commit ae6064d into JuliaAttic:master May 8, 2015
@MichaelHatherly
Copy link
Contributor Author

Thanks.

@MichaelHatherly MichaelHatherly deleted the mh/markdown-backport branch May 8, 2015 09:56
@hayd
Copy link

hayd commented Jun 9, 2015

Probably the thing to do here is to get people to use @compat using Base.Markdown. The tricky part is: what should people put in their REQUIRES?

@MikeInnes
Copy link
Contributor

Installing Markdown.jl in 0.4 is redundant but not exactly that bad – I say just put it in requires as usual.

@hayd
Copy link

hayd commented Jun 9, 2015

I get warning messages in 0.4:

julia> using Markdown
warning: use `@compat using Markdown` to support julia 0.3+
Warning: using Markdown.Markdown in module Main conflicts with an existing identifier.

# new session
julia> @compat using Markdown
warning: use `@compat using Markdown` to support julia 0.3+
Warning: using Markdown.Markdown in module Main conflicts with an existing identifier.

I'm not sure where this message is coming from, but IMO it should say @compat using Base.Markdown, and we put something in compat to handle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants