install stage0: log to firstrunsetup #6988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
MichaIng
reviewed
Mar 27, 2024
When debugging firstrun issues, stage0 doesn't have any logs which makes it hard to debug. Log stage0 to /var/tmp/dietpi/logs/dietpi-firstrun-setup.log Change stage1 logging to append to this log instead of clobbering it.
MichaIng
approved these changes
Mar 27, 2024
|
Indeed it could be also done in Since this is a crucial part of the first run setup, it makes sense to have also the update and those check results in the related president log file, which is also shown in the error handler when running it interactively. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging firstrun issues, stage0 doesn't have any logs which makes it hard to debug.
Log stage0 to /var/tmp/dietpi/logs/dietpi-firstrun-setup.log
Change stage1 logging to append to this log instead of clobbering it.
This could probably be also fixed to improving logging to dietpi-update.log (it only starts with 'Applying pre-patches' and doesn't include the requirement check / checking for available updates)
But in case of install stage 0 / 1 failure, the user is asked to provide the firstrun-setup.log so it seems somewhat logical to just use that.